Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ServiceMonitor CRD #689

Closed
benoittoulme opened this issue Mar 6, 2023 · 6 comments
Closed

Support ServiceMonitor CRD #689

benoittoulme opened this issue Mar 6, 2023 · 6 comments
Labels
enhancement New feature or request Splunk Observability Issue related to Splunk Observability destination Stale

Comments

@benoittoulme
Copy link

Prometheus uses ServiceMonitor CRDs to discover the endpoints to call to pull metrics.

It looks like otel also supports ServiceMonitor CRDs:
open-telemetry/opentelemetry-operator#653
open-telemetry/opentelemetry-operator#383

This support was added in release v0.61.0 https://github.com/open-telemetry/opentelemetry-operator/releases/tag/v0.61.0

Ask: Have the Splunk Otel Collector support ServiceMonitor CRDs. This is already supported in otel, so hopefully not too much work. It would make it easier for users to use the same standards to setup metrics ingest into Splunk; And the ServiceMonitor CRD contains additional features that the current annotation-based model does not support - for example, use authentication when executing requests to pull metrics.

@atoulme atoulme added enhancement New feature or request Splunk Observability Issue related to Splunk Observability destination labels Mar 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Oct 10, 2023
@conrad784
Copy link

ServiceMonitors are very usefull as the normal prometheus annotation does not work if the monitored endpoint is behind authentication. Also a lot of helm charts only implement ServiceMonitor.

@atoulme
Copy link
Contributor

atoulme commented Nov 22, 2023

Moving to a Splunk Idea: https://ideas.splunk.com/ideas/SFXIMMID-I-571

Please add your votes there to get this prioritized.

@atoulme
Copy link
Contributor

atoulme commented May 29, 2024

Work continues on the Splunk idea.

@atoulme atoulme closed this as not planned Won't fix, can't repro, duplicate, stale May 29, 2024
@MB175
Copy link

MB175 commented Nov 27, 2024

@benoittoulme so how to I configure prometheus in the Otel config so it recognises CRDs (ServiceMonitors) ?

@mpepping
Copy link
Contributor

so how to I configure prometheus in the Otel config so it recognises CRDs (ServiceMonitors) ?

@MB175 this should help: https://github.com/signalfx/splunk-otel-collector-chart/blob/splunk-otel-collector-0.113.0/helm-charts/splunk-otel-collector/values.yaml#L1278-L1280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Splunk Observability Issue related to Splunk Observability destination Stale
Projects
None yet
Development

No branches or pull requests

5 participants