-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instrumentation for confluent-kafka-go #100
Conversation
Codecov Report
@@ Coverage Diff @@
## main #100 +/- ##
==========================================
+ Coverage 81.32% 83.52% +2.19%
==========================================
Files 23 27 +4
Lines 889 1159 +270
==========================================
+ Hits 723 968 +245
- Misses 134 155 +21
- Partials 32 36 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
1872f72
to
75f8786
Compare
e5e1305
to
d0abcd6
Compare
d0abcd6
to
01c54e8
Compare
This reverts commit 01c54e8.
@pellared thoughts on how we can exclude this package from being built on certain systems? confluent-kafka-go is not supported on Windows and it looks like Ubuntu 20.04 does not have a build of librdkafka-dev for i386 machine architecture. |
To handle Windows, I would try adding the following build constraint to all files:
For Ubuntu, I would add a step in GH workflow to install the package in the jobs where it is needed. |
Tried that. The package could not be found :| |
5bf89c9
to
7f6cb64
Compare
Guessing you meant |
e2062e7
to
8fcebca
Compare
This reverts commit bdddadb.
c676569
to
2700b7c
Compare
f2ef618
to
112444f
Compare
8117f2c
to
6bf9cc9
Compare
6bf9cc9
to
cf6e6d8
Compare
instrumentation/github.com/confluentinc/confluent-kafka-go/kafka/splunkkafka/test/kafka_test.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/confluentinc/confluent-kafka-go/kafka/splunkkafka/test/kafka_test.go
Show resolved
Hide resolved
instrumentation/github.com/confluentinc/confluent-kafka-go/kafka/splunkkafka/test/kafka_test.go
Outdated
Show resolved
Hide resolved
3636e62
to
4842250
Compare
This new module instruments the built-in
confluent-kafka-go/kafka
package. This instrumentation wraps theConsumer
andProducer
from the instrumented package. Kafka messages received and sent, both synchronously and asynchronously, are traced. The message headers are used to propagate trace context with a configurableTextMapPropagtor
.