Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the splunksql package #124

Merged
merged 3 commits into from
Sep 28, 2021
Merged

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Sep 24, 2021

Resolve #103

@MrAlias MrAlias requested review from a team as code owners September 24, 2021 20:19
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2021

Codecov Report

Merging #124 (78b580c) into main (96b06ee) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage   81.07%   81.07%           
=======================================
  Files          21       21           
  Lines         856      856           
=======================================
  Hits          694      694           
  Misses        130      130           
  Partials       32       32           
Flag Coverage Δ
Linux 79.90% <ø> (ø)
Windows 80.37% <ø> (ø)
macOS 79.20% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96b06ee...78b580c. Read the comment docs.

Copy link
Contributor

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW WDYT about #88 (comment)?

@pellared
Copy link
Contributor

Do you think it would be valuable to documented what spans, attributes, events are created using this package?

@MrAlias
Copy link
Contributor Author

MrAlias commented Sep 27, 2021

Do you think it would be valuable to documented what spans, attributes, events are created using this package?

This seems like something that would become stale easily. Having stale docs can cause more harm then good.

@MrAlias
Copy link
Contributor Author

MrAlias commented Sep 27, 2021

BTW WDYT about #88 (comment)?

I like the idea, but I'm not entirely sure how to include an attribute from the context without adding some additional functionality. I'd be interested in seeing an example if you have one, but I would also not want to block this PR on including that. What do you think @pellared?

@pellared pellared merged commit 0465ade into signalfx:main Sep 28, 2021
@MrAlias MrAlias deleted the doc-splunksql branch September 28, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add README to splunksql package
3 participants