-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the splunksql package #124
Conversation
Codecov Report
@@ Coverage Diff @@
## main #124 +/- ##
=======================================
Coverage 81.07% 81.07%
=======================================
Files 21 21
Lines 856 856
=======================================
Hits 694 694
Misses 130 130
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW WDYT about #88 (comment)?
Do you think it would be valuable to documented what spans, attributes, events are created using this package? |
This seems like something that would become stale easily. Having stale docs can cause more harm then good. |
I like the idea, but I'm not entirely sure how to include an attribute from the context without adding some additional functionality. I'd be interested in seeing an example if you have one, but I would also not want to block this PR on including that. What do you think @pellared? |
Resolve #103