-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add miekg/dns instrumentation #155
Conversation
Codecov Report
@@ Coverage Diff @@
## main #155 +/- ##
==========================================
+ Coverage 69.19% 70.83% +1.63%
==========================================
Files 29 33 +4
Lines 1422 1529 +107
==========================================
+ Hits 984 1083 +99
- Misses 401 407 +6
- Partials 37 39 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Entry in CHANGELOG.md
is missing 😉
I have reviewed it quickly. It would be better if @TomRoSystems would give it another pass.
instrumentation/github.com/miekg/dns/splunkdns/test/client_test.go
Outdated
Show resolved
Hide resolved
errCh <- server.ActivateAndServe() | ||
}() | ||
t.Cleanup(func() { | ||
assert.NoError(t, <-errCh, "failed to start server") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
assert.NoError(t, <-errCh, "failed to start server") | |
assert.NoError(t, <-errCh, "server.ActivateAndServe returned an error") |
as there may be multiple reasons why it returns an error
moreover, I hope this error message would make it easier to find where the error comes from
This new module instruments the
github.com/miekg/dns
package.