Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add miekg/dns instrumentation #155

Merged
merged 17 commits into from
Nov 5, 2021
Merged

Add miekg/dns instrumentation #155

merged 17 commits into from
Nov 5, 2021

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Oct 13, 2021

This new module instruments the github.com/miekg/dns package.

  • Comply with OpenTelemetry semantic conventions (there are currently no requirements)
  • Package documentation
  • Exported objects are documented
  • Tests and linting are passing
  • Includes dependabot config
  • Library added to README.md
  • CHANGELOG.md updated

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2021

Codecov Report

Merging #155 (39bf8e7) into main (cad2c87) will increase coverage by 1.63%.
The diff coverage is 92.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
+ Coverage   69.19%   70.83%   +1.63%     
==========================================
  Files          29       33       +4     
  Lines        1422     1529     +107     
==========================================
+ Hits          984     1083      +99     
- Misses        401      407       +6     
- Partials       37       39       +2     
Flag Coverage Δ
Linux 70.17% <92.52%> (+1.68%) ⬆️
Windows 65.94% <92.52%> (+2.49%) ⬆️
macOS 67.49% <92.52%> (+1.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...trumentation/github.com/miekg/dns/splunkdns/dns.go 69.23% <69.23%> (ø)
...mentation/github.com/miekg/dns/splunkdns/config.go 93.75% <93.75%> (ø)
...mentation/github.com/miekg/dns/splunkdns/client.go 100.00% <100.00%> (ø)
...entation/github.com/miekg/dns/splunkdns/handler.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cad2c87...39bf8e7. Read the comment docs.

@MrAlias MrAlias marked this pull request as ready for review October 14, 2021 15:27
@MrAlias MrAlias requested review from a team as code owners October 14, 2021 15:27
Copy link
Contributor

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entry in CHANGELOG.md is missing 😉

I have reviewed it quickly. It would be better if @TomRoSystems would give it another pass.

@pellared pellared requested a review from TomRoSystems October 15, 2021 23:26
@MrAlias MrAlias merged commit b32d683 into signalfx:main Nov 5, 2021
@MrAlias MrAlias deleted the splunkdns branch November 5, 2021 18:28
errCh <- server.ActivateAndServe()
}()
t.Cleanup(func() {
assert.NoError(t, <-errCh, "failed to start server")
Copy link
Contributor

@pellared pellared Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
assert.NoError(t, <-errCh, "failed to start server")
assert.NoError(t, <-errCh, "server.ActivateAndServe returned an error")

as there may be multiple reasons why it returns an error

moreover, I hope this error message would make it easier to find where the error comes from

@MrAlias MrAlias mentioned this pull request Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants