-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix splunksql DB goroutine leak #1682
Conversation
Codecov ReportBase: 81.86% // Head: 81.93% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1682 +/- ##
==========================================
+ Coverage 81.86% 81.93% +0.06%
==========================================
Files 63 63
Lines 2625 2651 +26
==========================================
+ Hits 2149 2172 +23
- Misses 428 430 +2
- Partials 48 49 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
If the underlying types implement Close as well, the call to Close will be forwarded to them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍
PS. I spent about ~2 hours reviewing this PR... And I was adding and later deleting comments a few times 😆 But everything is well structured, tested, and the comments are great!
Co-authored-by: Robert Pająk <pellared@hotmail.com>
fix #1676
fix #1677
The
Open
function from thesplunksql
instrumentation opens a database to determine the underlying connector or driver. It never closes this database. Update the function that returns the initial database in a way where a user closes the returned database also closes the initial database.This resolves the issue of the database goroutine being abandoned.