Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github.com/go-chi/chi instrumentation #227

Merged
merged 14 commits into from
Dec 14, 2021
Merged

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Dec 2, 2021

This new module instruments the github.com/go-chi/chi package.

  • Comply with OpenTelemetry HTTP semantic conventions
  • Package documentation
  • Exported objects are documented
  • Tests and linting are passing
  • Includes dependabot config
  • Library added to README.md
  • CHANGELOG.md updated

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2021

Codecov Report

Merging #227 (8617049) into main (f051a59) will decrease coverage by 0.12%.
The diff coverage is 92.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
- Coverage   77.12%   77.00%   -0.13%     
==========================================
  Files          43       45       +2     
  Lines        2037     2087      +50     
==========================================
+ Hits         1571     1607      +36     
- Misses        425      437      +12     
- Partials       41       43       +2     
Flag Coverage Δ
Linux 77.00% <92.00%> (+0.36%) ⬆️
Windows ?
macOS 75.03% <92.00%> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...entation/github.com/go-chi/chi/splunkchi/option.go 69.23% <69.23%> (ø)
...rumentation/github.com/go-chi/chi/splunkchi/chi.go 100.00% <100.00%> (ø)
...n/github.com/lib/pq/splunkpq/internal/connector.go 51.75% <0.00%> (-5.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f051a59...8617049. Read the comment docs.

@MrAlias MrAlias marked this pull request as ready for review December 3, 2021 20:23
@MrAlias MrAlias requested review from a team as code owners December 3, 2021 20:23
@MrAlias MrAlias requested a review from TomRoSystems December 3, 2021 20:24
@MrAlias MrAlias enabled auto-merge (squash) December 3, 2021 20:27
@MrAlias MrAlias changed the title [WIP] Add github.com/go-chi/chi instrumentation Add github.com/go-chi/chi instrumentation Dec 3, 2021
@MrAlias MrAlias merged commit ed64e83 into signalfx:main Dec 14, 2021
@MrAlias MrAlias deleted the splunkchi branch December 14, 2021 16:16
@MrAlias MrAlias mentioned this pull request Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants