Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github.com/julienschmidt/httprouter instrumentation #273

Merged
merged 3 commits into from
Dec 14, 2021

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Dec 13, 2021

This new module instruments the github.com/julienschmidt/httprouter module.

  • Comply with OpenTelemetry HTTP semantic conventions
  • Package documentation
  • Exported objects are documented
  • Tests and linting are passing
  • Includes dependabot config
  • Library added to README.md
  • CHANGELOG.md updated

@MrAlias MrAlias force-pushed the splunkhttprouter branch 2 times, most recently from c6327bb to ed449a8 Compare December 13, 2021 22:15
@MrAlias MrAlias requested a review from TomRoSystems December 13, 2021 22:22
@MrAlias MrAlias marked this pull request as ready for review December 13, 2021 22:29
@MrAlias MrAlias requested review from a team as code owners December 13, 2021 22:29
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2021

Codecov Report

Merging #273 (55e64d7) into main (fc5ab1d) will increase coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #273      +/-   ##
==========================================
+ Coverage   77.01%   77.27%   +0.26%     
==========================================
  Files          47       48       +1     
  Lines        2149     2174      +25     
==========================================
+ Hits         1655     1680      +25     
  Misses        449      449              
  Partials       45       45              
Flag Coverage Δ
Linux 77.27% <100.00%> (+0.26%) ⬆️
macOS 75.39% <100.00%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nschmidt/httprouter/splunkhttprouter/httprouter.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc5ab1d...55e64d7. Read the comment docs.

@MrAlias MrAlias enabled auto-merge (squash) December 14, 2021 17:05
@MrAlias MrAlias merged commit 07ced3f into signalfx:main Dec 14, 2021
@MrAlias MrAlias deleted the splunkhttprouter branch December 14, 2021 17:18
@MrAlias MrAlias mentioned this pull request Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants