Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OTEL_PROPAGATORS in distro #295

Merged
merged 20 commits into from
Jan 17, 2022
Merged

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Dec 17, 2021

Required by the GDI specification.

@MrAlias MrAlias requested review from a team as code owners December 17, 2021 00:24
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2021

Codecov Report

Merging #295 (17f114b) into main (8ec2c9e) will increase coverage by 0.52%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
+ Coverage   78.56%   79.08%   +0.52%     
==========================================
  Files          53       53              
  Lines        2570     2634      +64     
==========================================
+ Hits         2019     2083      +64     
  Misses        511      511              
  Partials       40       40              
Flag Coverage Δ
Linux 78.70% <100.00%> (+0.53%) ⬆️
Windows 74.94% <100.00%> (+0.69%) ⬆️
macOS 74.75% <100.00%> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
distro/config.go 100.00% <100.00%> (ø)
distro/otel.go 75.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ec2c9e...17f114b. Read the comment docs.

@MrAlias MrAlias requested a review from a team as a code owner December 17, 2021 20:15
@MrAlias MrAlias marked this pull request as draft December 20, 2021 19:50
@MrAlias
Copy link
Contributor Author

MrAlias commented Dec 20, 2021

Going to update docs and change to a lazy evaluation of the default props.

@MrAlias MrAlias marked this pull request as ready for review December 21, 2021 17:53
Copy link
Contributor

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a quick look. Looks very nice 👍
@TomRoSystems PTAL

distro/otel.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Robert Pająk <pellared@hotmail.com>
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work. just nit comments 😄

README.md Outdated Show resolved Hide resolved
distro/README.md Outdated Show resolved Hide resolved
distro/README.md Outdated Show resolved Hide resolved
distro/README.md Outdated Show resolved Hide resolved
distro/README.md Outdated Show resolved Hide resolved
distro/config.go Outdated Show resolved Hide resolved
@MrAlias MrAlias enabled auto-merge (squash) January 17, 2022 16:36
@MrAlias MrAlias merged commit 19c6f21 into signalfx:main Jan 17, 2022
@MrAlias MrAlias deleted the distro-propagation branch January 17, 2022 16:58
@MrAlias MrAlias mentioned this pull request Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants