Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OTEL_TRACES_EXPORTER in distro #300

Merged
merged 48 commits into from
Jan 26, 2022
Merged

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Dec 17, 2021

Add configuration of the tracing exporter used by the SDK via code options and environment variables.

Required by the GDI specification.

@MrAlias MrAlias force-pushed the distro-exporter branch 2 times, most recently from 46c0f33 to cc30ef3 Compare December 17, 2021 21:12
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2021

Codecov Report

Merging #300 (a7fafc5) into main (760f21e) will increase coverage by 0.59%.
The diff coverage is 100.00%.

❗ Current head a7fafc5 differs from pull request most recent head 3f5724a. Consider uploading reports for the commit 3f5724a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #300      +/-   ##
==========================================
+ Coverage   79.08%   79.67%   +0.59%     
==========================================
  Files          53       54       +1     
  Lines        2634     2696      +62     
==========================================
+ Hits         2083     2148      +65     
+ Misses        511      509       -2     
+ Partials       40       39       -1     
Flag Coverage Δ
Linux 79.30% <100.00%> (+0.60%) ⬆️
Windows 75.71% <100.00%> (+0.76%) ⬆️
macOS 75.44% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
distro/config.go 100.00% <100.00%> (ø)
distro/exporter.go 100.00% <100.00%> (ø)
distro/otel.go 79.31% <100.00%> (+4.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 760f21e...3f5724a. Read the comment docs.

@MrAlias MrAlias marked this pull request as ready for review January 23, 2022 16:13
@MrAlias MrAlias requested review from a team as code owners January 23, 2022 16:13
Copy link
Contributor

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

CHANGELOG.md Outdated Show resolved Hide resolved
distro/README.md Outdated Show resolved Hide resolved
distro/otel_test.go Outdated Show resolved Hide resolved
MrAlias and others added 2 commits January 25, 2022 14:39
Co-authored-by: Robert Pająk <rpajak@splunk.com>
@MrAlias MrAlias enabled auto-merge (squash) January 25, 2022 23:10
@MrAlias MrAlias merged commit c63c7b0 into signalfx:main Jan 26, 2022
@MrAlias MrAlias deleted the distro-exporter branch January 26, 2022 16:53
@MrAlias MrAlias mentioned this pull request Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants