Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Go 1.20 #3002

Merged
merged 7 commits into from
Apr 8, 2024
Merged

Drop support for Go 1.20 #3002

merged 7 commits into from
Apr 8, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Feb 28, 2024

Support for this version of Go is dropped upstream in the next release.

Copy link

github-actions bot commented Feb 28, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@MrAlias
Copy link
Contributor Author

MrAlias commented Feb 28, 2024

I have read the CLA Document and I hereby sign the CLA

srv-gh-o11y-gdi-cla added a commit to splunk/cla-agreement that referenced this pull request Feb 28, 2024
@MrAlias MrAlias marked this pull request as ready for review February 28, 2024 19:45
@MrAlias MrAlias requested review from a team as code owners February 28, 2024 19:45
@pellared
Copy link
Contributor

pellared commented Mar 1, 2024

I would rather merge it before bumping to newer OTel Go version as we may always need to create a bugfix (e.g. for an instrumentation library).

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.98%. Comparing base (53fe2aa) to head (4be46d3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3002   +/-   ##
=======================================
  Coverage   78.98%   78.98%           
=======================================
  Files          88       88           
  Lines        3403     3403           
=======================================
  Hits         2688     2688           
  Misses        641      641           
  Partials       74       74           
Flag Coverage Δ
Linux 80.04% <ø> (ø)
Windows 75.22% <ø> (ø)
macOS 76.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pellared pellared enabled auto-merge (squash) April 8, 2024 09:28
@pellared pellared merged commit 85e0fa9 into signalfx:main Apr 8, 2024
15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants