Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Splunk span limit defaults #723

Merged
merged 11 commits into from
Mar 30, 2022
Merged

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Mar 29, 2022

Conform with the GDI specification:

  • Distribution MUST default to 1000 for OTEL_SPAN_LINK_COUNT_LIMIT (not OpenTelemetry default)
  • Distribution MUST default to 12000 for OTEL_ATTRIBUTE_VALUE_LENGTH_LIMIT (not OpenTelemetry default)
  • Distribution MUST be unset "" (unlimited) for all others (not OpenTelemetry default)

@MrAlias MrAlias marked this pull request as ready for review March 29, 2022 20:08
@MrAlias MrAlias requested review from a team as code owners March 29, 2022 20:08
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2022

Codecov Report

Merging #723 (f3f50bb) into main (8ff26ac) will increase coverage by 0.47%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #723      +/-   ##
==========================================
+ Coverage   78.87%   79.34%   +0.47%     
==========================================
  Files          55       56       +1     
  Lines        2755     2818      +63     
==========================================
+ Hits         2173     2236      +63     
  Misses        533      533              
  Partials       49       49              
Flag Coverage Δ
Linux 79.34% <100.00%> (+0.47%) ⬆️
macOS 75.65% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
distro/config.go 100.00% <100.00%> (ø)
distro/limits.go 100.00% <100.00%> (ø)
distro/otel.go 64.40% <100.00%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ff26ac...f3f50bb. Read the comment docs.

distro/config_test.go Outdated Show resolved Hide resolved
distro/limits.go Outdated Show resolved Hide resolved
Copy link
Contributor

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to mention the env vars in the markdown docs. But it can be done later. Approving and merging.

@pellared pellared merged commit 703c2a9 into signalfx:main Mar 30, 2022
@pellared pellared changed the title Add Splunk span limit defaults Apply Splunk span limit defaults Mar 30, 2022
@MrAlias MrAlias deleted the span-limits branch March 30, 2022 17:13
@MrAlias MrAlias mentioned this pull request Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants