Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor sampler environment variable if set #724

Merged
merged 4 commits into from
Mar 30, 2022

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Mar 29, 2022

No description provided.

@MrAlias MrAlias requested review from a team as code owners March 29, 2022 20:56
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2022

Codecov Report

Merging #724 (050565e) into main (8ff26ac) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #724      +/-   ##
==========================================
+ Coverage   78.87%   78.89%   +0.02%     
==========================================
  Files          55       55              
  Lines        2755     2758       +3     
==========================================
+ Hits         2173     2176       +3     
  Misses        533      533              
  Partials       49       49              
Flag Coverage Δ
Linux 78.89% <100.00%> (+0.02%) ⬆️
macOS 75.12% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
distro/otel.go 65.57% <100.00%> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ff26ac...050565e. Read the comment docs.

Copy link
Contributor

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about updating the changelog?

@MrAlias MrAlias requested a review from a team as a code owner March 30, 2022 15:30
@MrAlias MrAlias enabled auto-merge (squash) March 30, 2022 15:30
@MrAlias MrAlias merged commit af4eabc into signalfx:main Mar 30, 2022
@MrAlias MrAlias deleted the sampler-envar branch March 30, 2022 15:43
@MrAlias MrAlias mentioned this pull request Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants