Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Splunk realm for endpoint if defined #725

Merged
merged 6 commits into from
Apr 1, 2022
Merged

Use Splunk realm for endpoint if defined #725

merged 6 commits into from
Apr 1, 2022

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Mar 30, 2022

No description provided.

@MrAlias MrAlias marked this pull request as ready for review March 30, 2022 21:32
@MrAlias MrAlias requested review from a team as code owners March 30, 2022 21:32
theletterf
theletterf approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. SPLUNK_REALM should be added to the settings docs though.

* - ``SPLUNK_REALM``
     - The name of your organization's realm, for example, ``us0``. When you set the realm, traces are sent to ``https://ingest.<realm>.signalfx.com/v2/trace``.
     - ```

pellared
pellared requested changes Mar 31, 2022
View reviewed changes
distro/exporter.go Outdated Show resolved Hide resolved
@pellared pellared merged commit 06ad318 into signalfx:main Apr 1, 2022
@MrAlias MrAlias deleted the splunk-realm branch April 1, 2022 16:06
@MrAlias MrAlias mentioned this pull request Apr 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pellared pellared pellared approved these changes

@theletterf theletterf theletterf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MrAlias @theletterf @pellared