-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minmize distro API #941
Minmize distro API #941
Conversation
Codecov Report
@@ Coverage Diff @@
## main #941 +/- ##
==========================================
- Coverage 79.80% 79.31% -0.49%
==========================================
Files 56 56
Lines 2832 2780 -52
==========================================
- Hits 2260 2205 -55
- Misses 525 527 +2
- Partials 47 48 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Minor docs concerns only.
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Why
Supporting only a single configuration method is simplifying the codebase and adoption.
From: https://github.com/signalfx/gdi-specification/blob/main/specification/configuration.md
What
github.com/signalfx/splunk-otel-go/distro
API tocontain only necessary option functions.
WithAccessToken
function,use
SPLUNK_ACCESS_TOKEN
environment variable instead.WithEndpoint
function,use one of the
OTEL_EXPORTER_OTLP_ENDPOINT
,OTEL_EXPORTER_OTLP_TRACES_ENDPOINT
,OTEL_EXPORTER_JAEGER_ENDPOINT
environment variables instead.
WithPropagator
function,use
OTEL_PROPAGATORS
environment variable instead.WithTraceExporter
function,use
OTEL_TRACES_EXPORTER
environment variable instead.distro/README.md
as I find our official doc in better shape. I plan to create adocs/advanced-config.go
based on our official doc in the following days. It should be easier to keep both of them in sync that way and the structure will be similar to our other distros.Testing
SPLUNK_REALM=us0
OTEL_TRACES_EXPORTER=jaeger-thrift-splunk SPLUNK_REALM=us0
OTEL_TRACES_EXPORTER=jaeger-thrift-splunk OTEL_EXPORTER_JAEGER_ENDPOINT=http://localhost:14268/api/traces