-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renegotiate media with different directions #1137
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Ammar Ansari <iammaransari@gmail.com>
Co-authored-by: Ammar Ansari <iammaransari@gmail.com>
Co-authored-by: Ammar Ansari <iammaransari@gmail.com>
Co-authored-by: Ammar Ansari <iammaransari@gmail.com>
Co-authored-by: Ammar Ansari <iammaransari@gmail.com>
Co-authored-by: Ammar Ansari <iammaransari@gmail.com>
Co-authored-by: Ammar Ansari <iammaransari@gmail.com>
Co-authored-by: Ammar Ansari <iammaransari@gmail.com>
// expect(statsAfterDisabling.inboundRTP).not.toHaveProperty('video') | ||
|
||
// Assert that outboundRTP.video is either absent or inactive | ||
if (statsAfterDisabling.outboundRTP.video) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we isolate these two cases to make the test more determinist?
In which case, it's expected to exist with active === false.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is something we need to first manually verify. We can try verifying this via WebRTC internals as well.
I observed inconsistent stats after disabling the video in the e2e test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting...
Description
ref: https://github.com/signalwire/cloud-product/issues/11648 & #1132
Allow users to renegotiate video, including the downgrade/upgrade of the RTC media peers.
cfRenegotiation
for Call Fabric renegotiation.Type of change
Code snippets