Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renegotiate media with different directions #1137

Open
wants to merge 72 commits into
base: main
Choose a base branch
from
Open

Renegotiate media with different directions #1137

Show file tree
Hide file tree
Changes from 51 commits
Commits
Show all changes
72 commits
Select commit Hold shift + click to select a range
451667e
testing
jpsantosbh Jul 17, 2024
0bbb68a
Merge branch 'main' into joao/renegotiation
jpsantosbh Jul 22, 2024
56ac7b5
cleanup
jpsantosbh Jul 22, 2024
b73d367
Merge branch 'main' into joao/renegotiation
jpsantosbh Sep 9, 2024
d312dc7
test hacking renegotiation passing
jpsantosbh Sep 11, 2024
f1cfd61
added renegotiateMedia
jpsantosbh Oct 2, 2024
9109a44
Merge branch 'main' into joao/renegotiation
jpsantosbh Oct 8, 2024
96b0c42
fix getMediaConstraints
jpsantosbh Oct 14, 2024
8607fa6
Merge branch 'joao/fix_media_constraints' into joao/renegotiation
jpsantosbh Oct 14, 2024
02b2d5c
start with offering true
jpsantosbh Oct 14, 2024
1249777
check MCU
jpsantosbh Oct 14, 2024
e350878
Merge branch 'main' into joao/renegotiation
jpsantosbh Oct 14, 2024
b7fcd79
changeset
jpsantosbh Oct 14, 2024
5708919
fixes
jpsantosbh Oct 15, 2024
46b833c
Update internal/e2e-js/tests/callfabric/renegotiation.spec.ts
jpsantosbh Oct 21, 2024
cbdacc0
Update packages/webrtc/src/RTCPeer.ts
jpsantosbh Oct 21, 2024
3a0be5f
Update packages/webrtc/src/RTCPeer.ts
jpsantosbh Oct 21, 2024
dec5f50
Update internal/e2e-js/tests/callfabric/renegotiation.spec.ts
jpsantosbh Oct 21, 2024
e5485e7
added to the public contract
jpsantosbh Oct 21, 2024
6231930
refactor
jpsantosbh Oct 21, 2024
2ca56ad
add to playground
jpsantosbh Oct 21, 2024
fc3803a
Merge branch 'main' into joao/renegotiation
jpsantosbh Oct 21, 2024
e821a1c
merge fix
jpsantosbh Oct 21, 2024
fb875a6
Update packages/webrtc/src/RTCPeer.ts
jpsantosbh Oct 22, 2024
a5ab32e
Update internal/playground-js/src/fabric/index.js
jpsantosbh Oct 22, 2024
3b9e3ea
use updateConstraints
jpsantosbh Oct 22, 2024
a89457a
Update packages/webrtc/src/BaseConnection.ts
jpsantosbh Oct 23, 2024
b401750
renaming
jpsantosbh Oct 23, 2024
e15d215
Update internal/e2e-js/tests/callfabric/renegotiation.spec.ts
jpsantosbh Oct 24, 2024
dd97f47
Merge branch 'main' into joao/renegotiation
jpsantosbh Oct 24, 2024
dd8fd6a
review
jpsantosbh Oct 24, 2024
613ce32
fix interface
jpsantosbh Oct 24, 2024
0833288
testing
jpsantosbh Jul 17, 2024
da30fef
added to the public contract
jpsantosbh Oct 21, 2024
4426dd7
fix interface
jpsantosbh Oct 24, 2024
dc1e18c
rengotiate with different direction
iAmmar7 Oct 25, 2024
e8eee01
fix build
iAmmar7 Oct 25, 2024
125ee6f
refactor the enableVideo logi
iAmmar7 Oct 25, 2024
b948222
refactor video media
iAmmar7 Oct 25, 2024
0d89795
correct api usage in e2e test
iAmmar7 Oct 25, 2024
4ee636d
update e2e tests
iAmmar7 Oct 25, 2024
73df834
update playwright config
iAmmar7 Oct 25, 2024
5e0c6a0
disable video method
iAmmar7 Oct 25, 2024
02c4455
refactor the media methods
iAmmar7 Oct 28, 2024
2cac04f
refactor types
iAmmar7 Oct 28, 2024
34ad127
include more e2e tests
iAmmar7 Oct 28, 2024
3f225d7
remove commits
iAmmar7 Oct 28, 2024
3ceec19
include disable video in e2e tests
iAmmar7 Oct 28, 2024
ba7b19d
update the default value for disableVideo method
iAmmar7 Oct 28, 2024
be13512
run tests
iAmmar7 Oct 28, 2024
9aac270
comment test issue
iAmmar7 Oct 28, 2024
99f32b0
set the offer when adding the transceiver
iAmmar7 Oct 29, 2024
af8c48e
refactor test
iAmmar7 Oct 29, 2024
f98ac95
include audio renegotiation as well
iAmmar7 Oct 29, 2024
4b97f40
update e2e test
iAmmar7 Oct 29, 2024
b640911
add negotiate audio tests
iAmmar7 Oct 29, 2024
ffd0799
remove branch from the CI
iAmmar7 Oct 29, 2024
8f43a77
update the changeset
iAmmar7 Oct 29, 2024
9f92488
update the changeset
iAmmar7 Oct 29, 2024
9d6c621
include test in the callfabric project
iAmmar7 Oct 29, 2024
8097d75
remove the enable video button
iAmmar7 Oct 29, 2024
0ea3fa0
remove helper changes
iAmmar7 Oct 29, 2024
1a5a4f4
remove helper changes
iAmmar7 Oct 29, 2024
02f95c9
introduce promise to wait for renegotiation
iAmmar7 Oct 31, 2024
38ad7e5
include sdp unit tests
iAmmar7 Oct 31, 2024
349672b
refacor video negotiation test
iAmmar7 Oct 31, 2024
d676c10
update negotiate audio test
iAmmar7 Oct 31, 2024
098bd5b
remove only from e2e test
iAmmar7 Oct 31, 2024
d965071
dedicated renegotiation project for playwright
iAmmar7 Oct 31, 2024
2eeaf3e
check for negotiation update
iAmmar7 Oct 31, 2024
fcb6425
refactor the toggleMedia code
iAmmar7 Oct 31, 2024
bca43b8
fix unit tests
iAmmar7 Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/sweet-garlics-tease.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@signalwire/webrtc': minor
---

Added public APIs for media renegotiation
2 changes: 1 addition & 1 deletion .github/workflows/unit-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
push:
branches: [main]
pull_request:
branches: [main, dev]
branches: [main, dev, joao/renegotiation]
iAmmar7 marked this conversation as resolved.
Show resolved Hide resolved
workflow_dispatch:

concurrency:
Expand Down
1 change: 1 addition & 0 deletions internal/e2e-js/playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ const callfabricTests = [
'raiseHand.spec.ts',
'reattach.spec.ts',
'relayApp.spec.ts',
'renegotiation.spec.ts',
'swml.spec.ts',
'videoRoom.spec.ts',
'videoRoomLayout.spec.ts',
Expand Down
Loading
Loading