Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shorten discv5 vote timeout and time pings per peer #2131

Closed
AgeManning opened this issue Dec 29, 2020 · 1 comment
Closed

Shorten discv5 vote timeout and time pings per peer #2131

AgeManning opened this issue Dec 29, 2020 · 1 comment
Labels
A1 enhancement New feature or request

Comments

@AgeManning
Copy link
Member

Description

Discv5 currently keeps IP voting history for 5 minutes as this is the time window for pinging peers. This makes it harder for malicious nodes to quickly manipulate our ENR IP, however it is less reactive.

For efficiency we also ping peers in our routing table every 5 minutes. This creates bursts of pings and again makes the ENR IP less reactive. We should revert back to using a DelayQueue structure for individual peers in the routing table and ping each peer with a 5 minute interval.

There is currently a known panic tokio's delayqueue, so we should hold off from doing this until that is resolved. tokio-rs/tokio#3270
@AgeManning AgeManning added enhancement New feature or request A1 labels Dec 29, 2020
@AgeManning AgeManning mentioned this issue Dec 29, 2020
Closed
@AgeManning AgeManning mentioned this issue Jan 7, 2021
Closed
@AgeManning
Copy link
Member Author

This has been resolved upstream in the discv5 repo. I modified the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A1 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AgeManning