Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator manager should accept 4 letter prefixes for mnemonic words #4797

Open
karalabe opened this issue Oct 1, 2023 · 2 comments
Open
Labels
enhancement New feature or request val-client Relates to the validator client binary

Comments

@karalabe
Copy link

karalabe commented Oct 1, 2023

Currently the validator manager when creating new validators requests the user to type in their mnemonic in full. Many cold wallets (i.e. the metal ones) only store the first 4 letters of each word as they uniquely identify the word. It would be nice if lighthouse would also accept 4 letter prefixes. Generally all tools that ingest mnemonics can handle this shortened notation.

@karalabe
Copy link
Author

karalabe commented Oct 1, 2023

E.g. The same feature implemented on the upstream deposit CLI: ethereum/staking-deposit-cli#242

@chong-he chong-he added val-client Relates to the validator client binary enhancement New feature or request labels Oct 1, 2023
@daviesalex
Copy link

daviesalex commented Jan 15, 2024

If for some reason supporting the 4 letter prefix isnt possible directly in the client, does it makes sense to change the "Invalid mnemonic" warning:

eprintln!("Invalid mnemonic");

to a prompt to enter full words from the bip-0039 wordlist (https://github.com/bitcoin/bips/blob/master/bip-0039/english.txt)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request val-client Relates to the validator client binary
Projects
None yet
Development

No branches or pull requests

3 participants