Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update attestation packing for Deneb #4825

Open
michaelsproul opened this issue Oct 11, 2023 · 1 comment
Open

Update attestation packing for Deneb #4825

michaelsproul opened this issue Oct 11, 2023 · 1 comment
Labels
blocked deneb optimization Something to make Lighthouse run more efficiently.

Comments

@michaelsproul
Copy link
Member

Description

Currently the lengthening of attestation validity in Deneb is not being taken advantage of in the op pool. We still filter attestations by the last 32 slots here:

.filter(|att| {
att.data.slot + spec.min_attestation_inclusion_delay <= state.slot()
&& state.slot() <= att.data.slot + T::slots_per_epoch()
})

Post-Deneb, we should be keeping any attestation from the current or previous epoch.

Steps to resolve

I propose we resolve this after merging Deneb to unstable, so as not to block it further. It's really just an optimisation to block packing to take advantage of the new Deneb rules. At the same time, block packing is being overhauled in #4507, so it might make sense to get that PR in before making this change.

@michaelsproul michaelsproul added optimization Something to make Lighthouse run more efficiently. deneb labels Oct 11, 2023
@realbigsean
Copy link
Member

realbigsean commented Oct 18, 2023

I'm gonna mark this blocked on #4507 for now, feel free to drop that tag though if we want it in sooner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked deneb optimization Something to make Lighthouse run more efficiently.
Projects
None yet
Development

No branches or pull requests

2 participants