Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp authority response verification during signing #2488

Open
haydentherapper opened this issue Nov 28, 2022 · 6 comments
Open

Timestamp authority response verification during signing #2488

haydentherapper opened this issue Nov 28, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@haydentherapper
Copy link
Contributor

Description

We should verify the response from the timestamp authority when it's received, as per RFC 3161:

Upon receiving the response (which is or includes a TimeStampResp
   that normally contains a TimeStampToken (TST), as defined below), the
   requesting entity SHALL verify the status error returned in the
   response and if no error is present it SHALL verify the various
   fields contained in the TimeStampToken and the validity of the
   digital signature of the TimeStampToken.

We'll need to add the timestamp-cert-chain flag for signing.

@haydentherapper haydentherapper added the enhancement New feature or request label Nov 28, 2022
@znewman01
Copy link
Contributor

+1 overall

-1 to the name timestamp-cert-chain for the reasons I describe in #2472

@haydentherapper
Copy link
Contributor Author

We can refactor that. This flag will also be unnecessary if you ship the TSA trust roots with TUF.

@znewman01
Copy link
Contributor

@haydentherapper and I discussed this; we decided go with --timestamp-cert-chain for now, then rename both this and --cert-chain as part of #2472.

@hectorj2f
Copy link
Contributor

@znewman01 I remember we initially used --timestamp-cert-chain but we recently renamed to --timestamp-certificate-chain. Do we still want to change it ?

@haydentherapper
Copy link
Contributor Author

I’m working on this now. Yea, I will use certificate-chain

@haydentherapper haydentherapper removed their assignment Mar 27, 2023
@haydentherapper
Copy link
Contributor Author

Removing myself from this if anyone else wants to take it on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants