Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ignoring x509 certificates when signing with a key via PKCS11 #3333

Closed
dylrich opened this issue Nov 2, 2023 · 0 comments · Fixed by #3334 or sigstore/docs#266
Closed

Support ignoring x509 certificates when signing with a key via PKCS11 #3333

dylrich opened this issue Nov 2, 2023 · 0 comments · Fixed by #3334 or sigstore/docs#266
Labels
enhancement New feature or request

Comments

@dylrich
Copy link
Contributor

dylrich commented Nov 2, 2023

If you're using Cosign's PKCS11 module and a key is loaded with a certificate attached to it, that certificate is always added to the signature. Cosign should support optionally disabling this to match the behavior available to keys not sourced via PKCS11. I have a pull request with a sample implementation of this and am happy to make any changes needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@dylrich