/api/v1/log/entries/retrieve returns 404 instead of 200 and empty result array

[bobcallaway]

Description

The SearchLogQuery endpoint (/api/v1/log/entries/retrieve) is documented in openapi.yaml to return a JSON array with 0 or more resulting entries that match the search criteria. There is 0 mention of returning a 404 from this endpoint.

If an request is searching for two entries (one that exists and one that doesn't), the server currently returns a 404 instead of just returning the one entry that actually exists in the log.

2a7899b181028bb64a5545cab55f0d2d54523b0de3e08c7f866d0c66a980a186676b6504c17d1355 exists but 2a7899b181028bb64a5545cab55f0d2d54523b0de3e08c7f866d0c66a980a186676b6504c17d1345 doesn't:

bcallaway@bcallaway01:~/git/sigstore/rekor$ curl -i -XPOST --data-binary '{"entryUUIDs":["2a7899b181028bb64a5545cab55f0d2d54523b0de3e08c7f866d0c66a980a186676b6504c17d1355","2a7899b181028bb64a5545cab55f0d2d54523b0de3e08c7f866d0c66a980a186676b6504c17d1345"]}' -H "Content-Type: application/json" http://localhost:3000/api/v1/log/entries/retrieve
HTTP/1.1 404 Not Found
Content-Type: application/json
Vary: Origin
Date: Sat, 22 Oct 2022 17:01:22 GMT
Content-Length: 134

{"code":404,"message":"error getting log entry for 2a7899b181028bb64a5545cab55f0d2d54523b0de3e08c7f866d0c66a980a186676b6504c17d1345"}

Expected:

bcallaway@bcallaway01:~/git/sigstore/rekor$ curl -XPOST --data-binary '{"entryUUIDs":["2a7899b181028bb64a5545cab55f0d2d54523b0de3e08c7f866d0c66a980a186676b6504c17d1355","2a7899b181028bb64a5545cab55f0d2d54523b0de3e08c7f866d0c66a980a186676b6504c17d1345"]}' -H "Content-Type: application/json" http://localhost:3000/api/v1/log/entries/retrieve
[{"2a7899b181028bb64a5545cab55f0d2d54523b0de3e08c7f866d0c66a980a186676b6504c17d1355":{"body":"eyJhcGlWZXJzaW9uIjoiMC4wLjEiLCJraW5kIjoicmVrb3JkIiwic3BlYyI6eyJkYXRhIjp7Imhhc2giOnsiYWxnb3JpdGhtIjoic2hhMjU2IiwidmFsdWUiOiI0NzhhNjkzYTdiZmUyNjRmZmNkOGZiMWJjMTNmYmFiNDRlZjQ0N2E2MGI4YzEyY2NmZDZkNjBlYzE5MTA1ZWYzIn19LCJzaWduYXR1cmUiOnsiY29udGVudCI6IkxTMHRMUzFDUlVkSlRpQlFSMUFnVTBsSFRrRlVWVkpGTFMwdExTMEtDbmR6UkdOQ1FVRkNRMEZCVVVKUlNtcFdRME5MUTFKRVdXOHJka0ZUU2swMk5HZEJRWEZ4WTAxQlIyNDRhbmw0YUN0WFFXNXFRbTgyYTBSWVJqUk5jUzhLZEVKSlNGUlpUMDFFUVcxaFFTdHpNMmR3ZUhScFFXbERhblpGTXpCV01EbFhhMEpTT0U1bE1FWnBjRnBPUjJGUVpVNTNjVEIzVm1wUWMxRkNTVkpYUVFwblExVjNaV2gyVFhKeGJXMXFLMlZvU2tORE5GSXZZVVppUVZWMFZuSjRNRkpsYm5jek5VYzBVbEJ4YlhwbFdHbDJNV1UwWTBwdmFqZExNamxRTkhsWkNqRkNaRVJOYm5oM09VYzFTbTkxVWtjeVVrOUJOR3hDUWxWWk1EaFRTVk51TXl0VlFuSkZNRkpVZUhCR1VsWXZTakZVVVZwTlpVaENRVmhxVjBWb01pc0tWbGhwTlhKU1UwTTVPR3hDVUdWVE1WbzRURWcwUzI4d2NXOUNXR3BxVnl0RE9HOUVLM2gwUVc5M1FtUm5OM2hZZVZsbU5XRjRUMHB0YnpKT1VVMVVjQXBMVm5samRYZEpSR0pCTURKS09HdE1aMWRaVkROQ01FZENTQzlwYms1NWJtTXJUVEZIWjB4Wk1VbFJUM2RMU0VrcmRVVndVRkZ5VTNkelZURjBTVTlqQ25CT00yTklPWE5WSzBkRGRrWnVhMnBXV2k5bE9IbElXWGsxYW5OS0syOTZiaTlYZWtGbWJIWlBUbTh5TUZoeVUwaEthbk55V0d4WmFHMXhhVGxsY0cwS1NVeEJRemM1YVc5TVpITlRNM2RQUWpWQllrMUhVV2x1UzNGS0wyNDJXWEUxUWpCdWNYQm5NRTk0ZVZoS01VaEVlbE5vTVVrdldETmhWMFl4ZEdrd1Z3cHRLMDVoV1V4aE4xTlNUamx1ZUcxM2VXeEVZa2xNV2twb1pUbE1ibVpCTUc1V1JuUnRiMUZ5WTJjOVBRbzlUVlZwWXdvdExTMHRMVVZPUkNCUVIxQWdVMGxIVGtGVVZWSkZMUzB0TFMwPSIsImZvcm1hdCI6InBncCIsInB1YmxpY0tleSI6eyJjb250ZW50IjoiTFMwdExTMUNSVWRKVGlCUVIxQWdVRlZDVEVsRElFdEZXU0JDVEU5RFN5MHRMUzB0Q2dwNGMwUk9Ra1l2TVRGbk1FSkVRVVJqYVdsRVVVdFphbGRxU1ZwWlZFWkROVFZyZW1GbU0wZzNWbU5xUzJJM1FXUkNVM2xJYzA0NFQwbGFka3hyWW1kNENqRk5OWGdyU2xCV1dFTnBRa1ZLVFdwd04xbERWa3BsVkZGWmFYaHBZelJGY0N0WlpVTTRla2xrVURoYVkzWk1SRGxpWjBaMWJYZHpLMVJDU2sxWk4zY0tNbU41TTI5UWRpOTFWbGMwVkZKR2RqUXlVSGRMYWs4dmMxaHdVbWN4WjBwNE0wVllNa1pLVml0aFdVRlFaRGhhTm5CSWVIVlBhelpLTkRsM1RGa3hSUW96YUd3eFduSlFSMVZIYzBZMGJEZDBWa2h1YVZwSE9FbDZWRU5uU2tkRE5uRnliSE5uTVZaSGNrbHJZV04wWlhOeU4xVTJLMWh6TkZaS1owNUpaRU56Q2pJdk4xSnhkMWRCZEd0VFNIVnRRVXRDWlRGb1Rsa3laR1IwTTNBME1tcEZUVEJRTW1jM1ZYZGhiemN2ZW1sVGFWTXZUamsyWkd0RlFXUlhRMVE1T1M4S1pUQnhURU0wY1RaV2FYTnlSblprYldaRVVYSlpOek5sWVdSTU5rcG1NemhJTWtsVmNFNXlZMGhuVmxwMFJVSkhhRVEyWkU5amFuTXlXVUphVG1aWU13cDNaa1JLYjI5U2F6QmxabU5NYkZOR1ZERlpWbHBvZUdWNkwzcGFWR1FyTjI1U1pVdFFiWE5QZUdsaFZXMVFMMkpSVTBJMFJscGFORnA0YzJaNFNESjBDbmRuV0RSa2RIZFNWakk0U2tkSVpVRXZTVk5LYVZkTlVVdHlZMmt4VUZKb1VsZEdNekpGWVVVMlpFWXJNbFpLZDBkcE9XMXpjMFZyUVVFcldVaG9NVThLU0dwUVoyOXpjVVp3TVRaeVlqRk5RVVZSUlVGQll6QmlWVzFXY21JelNXZFdSMVo2WkVOQk9HUkhWbnBrUlVKNVdsZDBkbU5wTld0YVdGa3JkM05GVlFwQ1FrMUNRMEZCSzBacFJVVmhVWGxIWVRGeFpqWXdaMlIwVkRCck1rdFFjbmRGYVZSUGRVbEdRV3d2TVRGbk1FTkhkMDFHUTFGUVExcDNRVVpEZDJ0SkNrSjNTVWRHVVc5S1EwRnpRMEpDV1VOQmQwVkRTR2RGUTBZMFFVRkRaMnRSTWt0UWNuZEZhVlJQZFVrdkwxRjJLMHQwYjJseVJVRllSSEZJTkhncmVqVUtTbE5LVm1SWGNrVjVWQzlHVFdGa2IwbHFNVFU0U1VoSU1XMUJlSEpRYm5ZMlFucEpOVXBzYzAxc01VcENUa3BKZFhwbFJXZGxTblZ6TjFnMVdUVkZOd3BFYWpGQ1ZsaEJOMWhKTkRscmJrUnpaVnBpUzNjeGRrMUVlazFKYVdGU1ZFOTBhRFZEV0RSUE5YRjNTMmMyY210M1dYSnVkVll2ZGxSb1Z6aFVaMVZyQ21KWmRtTlFhQ3RXU1hOUU5ESm5iMk5XUTNGWFp6RjFZWEpYV1cxQ1NrbERjVmQ0UTNST05IaGFTSE5NWW5aRmJHYzROa0ppWkc5RVEydG9ORTl0TjJNS0wyOWhibUUyWjA1VlpqVXJSMlZUTW5kaWJIQlFiMWd2YW1WNFVtcDJXRXBWUm5GSFlUQmhLMkZ4U3pCdWVuRlZSSFlyTUhWR1QxWkVaVTFRZVVNNWFncHlZbW96TW05NE1pOWtWMmd2WVhaT1dHNVlXRXBpY2xScmRWcEJUVEpEZURSTmNsSXdiRko1VFZCRlExbHhja2N6YlV0eWJsRnVSMEkyVHpKcVZWcGhDbGQ1UmpWNFQzWm9WVXR0ZFM5dlYxaGxVWEl2UTBWSlJVbzBRVFJuU1habmRFcEpWME54VGpZMGF6aEVhMkkxVjNCbmNXZDBPVXBqTlZSV2MxcENVMk1LTXpGMFFsQlFRV1ZKT1RaNmFGaHhiV3cwVTB0SlZEZGpVM0VyZGt4NGJHSk1hVVJCY0hkcWNrY3lTRGh4UmtsdFdtdFNiazlNVmxGSGQzSnpSbWxZZGdwcWNVZFNRM0pGZEVwMWNsZFBaMjh3T1V4dlMxY3ZjVTFoYTB3NGJ6bHVaMlJZUTNSSmRFZHZaMkYzVEd0QmJWWjZjMFJPUWtZdk1URm5NRUpFUVVOdkNqQndhakpyUTFoU1VHWjFTRkJ5Y20xa05scGpTRGhMU0ZKSFQxcDZlSFJoYVVWR2J5dDVOWEozY2xkRlJuTkljMlkyZW1wNFRraHVVQ3RzU0ZwaE1VVUtielJuUlU1S2JHVlRXa2hVWkd0RllVMVZVbk4yUTJKTGVYZEtNVEp1VmpOcWRIaDVVRlZ4WW0xWGFYSTNSa2xQV0ZkeFlqTlRZVzVCTVhCak9DOTVOZ3BCVG5FMVptMW1PRXRPTm5Sc2MyWmhOR1l3VWpacWVURm5Wa2xwVlhCRFNsRkVZa3hKVjNKaWRsUmtha2tyWVVoamJsaHVlSEF2U1VvMEsyMDVRMWRWQ21GV1RFcE5iMDlRTDFaek5UZFFPRTlFYkhGd1pIZHNXblJCVTBKd0syczNabmhMV2xOUE0yZHRXVTlHWWpkdk1XcFZPVWxOYmxOMUsxbGFSM2h3UW5nS1RsZGxUMXBCVjFaT2RXeEpTSFp0UWsxcFpFUjRXRWRzZUZBMVFXcFljbFI2Y21KR1RTODNWSFp2WlcxVGVWSkJhVXBYV2xwNGRXWjVjMVJvYjJGRmRBb3plSFpTWmpFek9HaE9kM3BWUWs5eGMyVjNjbWQxYmtad2RuWmtjME0xVkRndmVVczVTV2xyTVdSTVZESlRkMjlNZFdFd2FtSnJhV052TURoMU9WcDZDa3BNUWxkc1UyTlpNaXQ2TWxKNlJ6QkVNWGhEUnpORFJpdEJUSGhDYkdSRFNFMU1TV1p1ZFhZNGJEVlZORTFpYzJaVllrMDJjMnQwVTNnNGJtSlZRemNLT0dWV0wwOUlabGxvUkZwTFFtaHFXREZTTDJaWmRHbzVVWEV3TWpKa2NqbDVaM0EwWWpoMmJrVXhVelF4ZGs1c01WWnhXbUZLVEZneU0xRjFaVlV3UVFwRlVVVkJRV05NUVM5QlVWbEJVV2RCU21oWmFFSkhhMDFvYlhSaGJpdDBTVWhpVlRsS1RtbHFOamhDU1d0NmNtbENVVXBtT1dSWlRrRm9jMDFDVVd0RUNuZHRZMEZCUVc5S1JVNXBhalk0UWtscmVuSnBXbmcwVFVGS1MxTjJNa04zTVVaM05EVjVaazlEVm1kdE1tRXJNRUZpWW5aUFNsWk1jaTlNUVZrdlNFb0tiVE5KYWtJNFUwUjNiRmRqYUdVMFNGRlhhVVJZS3pZMWEwNHlUMHhRYUVFM1pVMDJlakJVZWxCNVRHOUNVWEF3YlVFclVFZFdlWFp1ZW0xV1NYVXdjUXBNVUhST1RUbE5UMWx2U1ZoNGNVSnlXVnA2Y2pkS0swMXFNMWxZVWpoVE5HRklhMkZPTVVNM2RuSkljVVZ6T1doUWNqWnRUM1VyVDFwbGNubEJXRlJtQ2xOT1RUWktSR0ZtY1dveVoyWjBjRU5HTmtWUloxZDVkRUl5TUhGSU1XMTFSbGt4UWxweVZTOXBTU3RZVFRrdk5XcDFkMkoxUzNSdGNIbGlha0p5T1ZRS05uSkdRVGd4Vm5kRU1GWlVUMHhMV1NzeGMzZGhWMjh6YWtoYWJtTnRkbVJXVVRsQlYwaENZMWh3VkhkRmVtVldNV3ROTUN0aFdVZ3dOSEZYZDAxS1NBb3ZkalJETDBGdWJtRkdTRVZFVFdsaUsxZEhOV1ZRV0VVclVHdHJWelZSVTNOQ1pHOUZaMnN6VTBwdmJIQmtWVWcwYTFaMlRtUlFWVTExUjI5S1NGWlFDbVoyVG14SmNXTnplRWx4TWpob056RlJORGR2Ymt4cFlVSm1iMGxQVFRoNk9WYzNNVzl0U0U5eFduQldVblJyTldwQmJVaHRhVTkwV1haUGVrTXZWWElLTUVveGVWbE5VbTl5YUdZck4xaFFOVFZoU1RKUGQyTlVaVzVPVTB0eVowMXRSblJRWjBsSFMyOTJSV1JwZUVReVpuZ3hVRE50TXpadGFXOXVXRkU1VlFwWFVqWkdkamQ1VTBoVWJEZGpVVEV6YWtkdFUxSXhUamhvWnowOUNqMHdOMmx5Q2kwdExTMHRSVTVFSUZCSFVDQlFWVUpNU1VNZ1MwVlpJRUpNVDBOTExTMHRMUzA9In19fX0=","integratedTime":1666457738,"logID":"68f87a6650aa1f4ce95cf645f69a2183fbb87cb0719daedee9c9aa8019134d0b","logIndex":1,"verification":{"inclusionProof":{"checkpoint":"b7d060183cf3 - 3060364934450940854\n75\nWrg1mCylbTIvrWaJNFXVA/G7y5uVQnf0lyThkq12LcA=\nTimestamp: 1666457857262976311\n\n— b7d060183cf3 aPh6ZjBGAiEA/nOJNf5CZB+PUJbwMOI3X3Hn1CgYDgXtChEN6+KSUagCIQC1NZCoroSh5DJpZsiYbkLplRbnkHtxPa0jspBu7vR8cw==\n","hashes":["154c13bf9ab1360f9de1f11fcd5dd4045b44b915b5e2fe032873b121ded1eac7","97962f5716439d51e0e18d17a6f52d21f9cdf940c8efd29ccb13417e4b3a7edb","723f99e78a9710ffceb87c91136d448bb0fc86902aa7a2c810e997bbd6b2ec3f","c8b2bc82e8e2dd93f94ee07f562189f6f79c7b2d2d6845886e0b47a9279159fb","32c5c8dea6d24ed0828dade4b7a79d1d0b640661663a3e4a985f9ee6ac1dd929","65ffc13bbe662ecc8087ebe95d4e0526e4c1cedbfddfba60cbcab9bb3b696817","0695e089334e232f4c985f56a002c347d4e075a14515723a3a2814d8cfb23258"],"logIndex":1,"rootHash":"5ab835982ca56d322fad66893455d503f1bbcb9b954277f49724e192ad762dc0","treeSize":75},"signedEntryTimestamp":"MEYCIQDVCFkbxNC+iRVz2MbM8RjMcfzolcxLLBOItlRfsS7QIwIhAJmVR8gmA8iKxzAu620+F+Unc+uNI0Lmx0IGhdFq/BLR"}}}]

Version
v1.0.0