Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please consider adding a getClusterMetricsAsJSON funtion #470

Open
PatrLind opened this issue Oct 1, 2021 · 1 comment · May be fixed by #471
Open

Please consider adding a getClusterMetricsAsJSON funtion #470

PatrLind opened this issue Oct 1, 2021 · 1 comment · May be fixed by #471

Comments

@PatrLind
Copy link

PatrLind commented Oct 1, 2021

At the moment it seems the cluster metrics are only available in the string format and not the JSON format.
I seems like it would be trivial to also add the JSON variant to the clusterMetrics function as well.
This way it would mirror how the non clustered metrics Registry interface work.
@SimenB
Copy link
Collaborator

SimenB commented Oct 1, 2021

Feel free to send a PR 🙂

@PatrLind PatrLind linked a pull request Oct 1, 2021 that will close this issue
Open
@zbjornson zbjornson linked a pull request Nov 13, 2021 that will close this issue
Support for getting clustered metrics as object #471
Open
@zbjornson zbjornson mentioned this issue Mar 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support for getting clustered metrics as object PatrLind/prom-client
2 participants
@SimenB @PatrLind