Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should not cache 3xx responses #33

Closed
danlsgiga opened this issue Oct 8, 2020 · 2 comments
Closed

Should not cache 3xx responses #33

danlsgiga opened this issue Oct 8, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@danlsgiga
Copy link

As I'm evaluating this module, I noticed that it is not handling origin responses like 302 (Redirect). cdp-cache is responding with a 200 to the browser, therefore the redirect never happens!

A way to reproduce is just to proxy to an origin that does a 302 or 301.

Additionaly, it would be nice to control what responses we want to cache, usually only 200's
@danlsgiga danlsgiga mentioned this issue Oct 9, 2020
Closed
@sillygod
Copy link
Owner

Hi @danlsgiga,

Thanks for finding this issue and sorry for responding late.
Recently, I am busy with other projects so I need some time to check this your PR.

@sillygod sillygod added the bug Something isn't working label Dec 12, 2020
@sillygod
Copy link
Owner

I'll close this issue because this bug has been fixed by another pull request #36 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 3xx responses from upstream
2 participants
@danlsgiga @sillygod