Upgrade to PHPUnit 11

[emteknetnz]

Acceptance criteria

• Upgrade to PHPUnit 11 for CMS 6
• Ensure any deprecation warnings in PHPUnit 9 have been resolved e.g. Expecting E_DEPRECATED and E_USER_DEPRECATED is deprecated and will no longer be possible in PHPUnit 10.

Notes

• Used https://github.com/emteknetnz/phpunit11-writer to automatically update tests
• Also manually did updates to fix some tests
• dataProviders are now static functions
• annotations converted to attributes, most notably dataProvider
• old code coverage annotations were removed rather than converted
• addMethods() changed to onlyMethods()
• ->will($this->returnValue(...)) manually changed to ->willReturn(...)
• ->will($this->returnCallback(...)) manually changed to ->willReturnCallback(...)
• ->withConsecutive(...) manually changed to a willReturnCallback(...) solution
• abstract tests are no longer allowed (presumably only if in /tests/ dir, because SapphireTest + FunctionalTest are OK)
• keys in dataProvider data must now match param names
• expectNotice() / expectWarning() / expectStrict() / expectDeprecation() have all been removed

CMS 5 PRs

• API Deprecate SSListExporter silverstripe-framework#11376

Recipe sink CI CMS 6

• https://github.com/creative-commoners/recipe-kitchen-sink/actions/runs/10914242453

CMS 6 PRs (ensure CMS 5 PRs are merged, merged-up and rebased on before merging these)

• FIX Handle PHPUnit 11 gha-run-tests#38
• ENH Show deprecations in phpunit 11.3.3 and above gha-run-tests#39
• DEP Use PHPUnit 11 recipe-testing#27
• DEP Use PHPUnit 11 silverstripe-framework#11361
• DEP Use PHPUnit 11 bringyourownideas/silverstripe-composer-update-checker#96
• DEP Use PHPUnit 11 bringyourownideas/silverstripe-maintenance#238
• DEP Use PHPUnit 11 silverstripe-elemental#1253
• DEP Use PHPUnit 11 silverstripe-admin#1822
• DEP Use PHPUnit 11 silverstripe-assets#638
• DEP Use PHPUnit 11 silverstripe-auditor#91
• DEP Use PHPUnit 11 silverstripe-behat-extension#284
• DEP Use PHPUnit 11 silverstripe-blog#784
• DEP Use PHPUnit 11 silverstripe-campaign-admin#329
• DEP Use PHPUnit 11 silverstripe-cms#3000
• DEP Use PHPUnit 11 silverstripe-config#123
• DEP Use PHPUnit 11 silverstripe-crontask#92
• DEP Use PHPUnit 11 silverstripe-documentconverter#98
• DEP Use PHPUnit 11 silverstripe-asset-admin#1494
• DEP Use PHPUnit 11 silverstripe-dynamodb#69
• DEP Use PHPUnit 11 silverstripe-environmentcheck#111
• DEP Use PHPUnit 11 silverstripe-errorpage#121
• DEP Use PHPUnit 11 silverstripe-event-dispatcher#29
• DEP Use PHPUnit 11 silverstripe-externallinks#146
• DEP Use PHPUnit 11 silverstripe-graphql#601
• DEP Use PHPUnit 11 silverstripe-graphql-devtools#59
• DEP Use PHPUnit 11 silverstripe-gridfieldqueuedexport#124
• DEP Use PHPUnit 11 silverstripe-hybridsessions#112
• DEP Use PHPUnit 11 silverstripe-iframe#97
• DEP Use PHPUnit 11 silverstripe-installer#378
• DEP Use PHPUnit 11 silverstripe-ldap#90
• DEP Use PHPUnit 11 silverstripe-linkfield#330
• DEP Use PHPUnit 11 silverstripe-login-forms#200
• DEP Use PHPUnit 11 silverstripe-lumberjack#171
• DEP Use PHPUnit 11 silverstripe-mfa#565
• DEP Use PHPUnit 11 silverstripe-mimevalidator#83
• DEP Use PHPUnit 11 silverstripe-realme#161
• DEP Use PHPUnit 11 recipe-authoring-tools#41
• DEP Use PHPUnit 11 recipe-blog#59
• DEP Use PHPUnit 11 recipe-cms#91
• DEP Use PHPUnit 11 recipe-collaboration#37
• DEP Use PHPUnit 11 recipe-content-blocks#47
• DEP Use PHPUnit 11 recipe-core#100
• DEP Use PHPUnit 11 recipe-form-building#40
• DEP Use PHPUnit 11 recipe-reporting-tools#49
• DEP Use PHPUnit 11 recipe-services#40
• DEP Use PHPUnit 11 silverstripe-registry#106
• DEP Use PHPUnit 11 silverstripe-reports#194
• DEP Use PHPUnit 11 silverstripe-restfulserver#134
• DEP Use PHPUnit 11 silverstripe-securityreport#88
• DEP Use PHPUnit 11 silverstripe-segment-field#125
• DEP Use PHPUnit 11 silverstripe-session-manager#219
• DEP Use PHPUnit 11 silverstripe-sharedraftcontent#260
• DEP Use PHPUnit 11 silverstripe-siteconfig#175
• DEP Use PHPUnit 11 silverstripe-sitewidecontent-report#106
• DEP Use PHPUnit 11 silverstripe-spamprotection#126
• DEP Use PHPUnit 11 silverstripe-staticpublishqueue#202
• DEP Use PHPUnit 11 silverstripe-subsites#598
• DEP Use PHPUnit 11 silverstripe-tagfield#306
• DEP Use PHPUnit 11 silverstripe-taxonomy#122
• DEP Use PHPUnit 11 silverstripe-textextraction#102
• DEP Use PHPUnit 11 silverstripe-totp-authenticator#174
• DEP Use PHPUnit 11 silverstripe-userforms#1326
• DEP Use PHPUnit 11 vendor-plugin#81
• DEP Use PHPUnit 11 silverstripe-versioned#473
• DEP Use PHPUnit 11 silverstripe-versioned-admin#362
• DEP Use PHPUnit 11 silverstripe-versionfeed#120
• DEP Use PHPUnit 11 silverstripe-webauthn-authenticator#198
• DEP Use PHPUnit 11 symbiote/silverstripe-advancedworkflow#553
• DEP Use PHPUnit 11 symbiote/silverstripe-gridfieldextensions#416
• DEP Use PHPUnit 11 symbiote/silverstripe-multivaluefield#119
• DEP Use PHPUnit 11 symbiote/silverstripe-queuedjobs#446
• DEP Use PHPUnit 11 tractorcow-farm/silverstripe-fluent#885
• DEP Use PHPUnit 11 tractorcow-farm/silverstripe-fluent#886
• DEP Use PHPUnit 11 silverstripe-contentreview#256
• DEP Use PHPUnit 11 dnadesign/silverstripe-elemental-userforms#100
• DEP Use PHPUnit 11 closure#3
• DEP Use PHPUnit 11 markdown-php-codesniffer#13
• DOC Update PHPUnit code sample developer-docs#583

Follow up PRs

• MNT Fix PHPUnit 12 deprecations silverstripe-mfa#567
• MNT Fix PHPUnit 12 deprecations bringyourownideas/silverstripe-maintenance#244

[GuySartorelli]

CMS 5 PR merged. Reassigning to Steve for CMS 6 PR prep

[GuySartorelli]

I do note "Ensure any deprecation warnings in PHPUnit 9 have been resolved" has been ticked though it seems not enough CMS 5 PRs to actually achieve that?

[GuySartorelli]

Changes required or questions asked in

• DEP Use PHPUnit 11 silverstripe-contentreview#256
• DEP Use PHPUnit 11 closure#3
• DOC Update PHPUnit code sample developer-docs#583

Some PRs also need a rebase.

[GuySartorelli]

PRs merged. I still don't think "Ensure any deprecation warnings in PHPUnit 9 have been resolved" is done? Reassigning to Steve to check that.

[GuySartorelli]

New PRs merged.

Reassigning to Steve because "Ensure any deprecation warnings in PHPUnit 9 have been resolved" still doesn't seem to have been done. The branches that are still running PHPUnit 9 still seem to have deprecation warnings.

[emteknetnz]

The AC of fixing phpunit 9 warnings meant fix it for CMS 6, not for CMS 5. I should have spelt that out clearer in the initial ACs.

Projects aren't going to be running our unit-tests so it does matters at all if we have a bunch of warnings about phpunit 10 in our CMS 5 builds, we've had them for probably well over a year at this point. If they still both you feel free to open a new card and link to the framework PR (I think) which has the custom error handler stuff which we'd need to backport to CMS 5 to resolve. Another option is just turn off phpunit deprecation warnings for CMS 5 builds because at this point they're irrelevant since we've just done the upgrade work in the CMS 6 branches.