Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog includes commits released on previous minor branch already #97

Open
chillu opened this issue Jul 26, 2018 · 3 comments
Open

Comments

@chillu
Copy link
Member

chillu commented Jul 26, 2018

Compare https://github.com/silverstripe/silverstripe-framework/blob/4/docs/en/04_Changelogs/beta/4.2.0-beta1.md with https://github.com/silverstripe/silverstripe-framework/blob/4/docs/en/04_Changelogs/4.1.2.md.

Both of them include a commit as the first item (silverstripe/silverstripe-framework@19fdebf) which was released with 4.1.2. So it shouldn't show up in the 4.2.0-beta1 changelog again. This is particularly high impact when it includes security releases, because it gives the false impression that users are getting security fixes (increasing their priority to upgrade), when they in fact might already have those security fixes in their project.

This is probably because the changelog does a diff via 4.1.0...4.2.0-beta1, rather than 4.1.<latest>...4.2.0-beta1.

@robbieaverill
Copy link

Yeah so a bug that you pointed out at the end there with not assuming the latest version correctly (how can you really assume it).

This could be fixed by #87 too, although I do agree with @tractorcow that it would add more work for the cow user. It still adds more flexibility too though.

@dhensby
Copy link

dhensby commented Jul 30, 2018

why can't cow figure out the previous release more accurately?

@tractorcow
Copy link

The bug is with the way that git log works. If you can fix the issue with git log commands you can port it to cow easily. it's not a cow specific issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants