Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMS 5: Final js build when we go RC #1436

Closed
GuySartorelli opened this issue Jan 11, 2023 · 1 comment
Closed

CMS 5: Final js build when we go RC #1436

GuySartorelli opened this issue Jan 11, 2023 · 1 comment

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Jan 11, 2023

Currently we are using alpha builds of https://www.npmjs.com/package/@silverstripe/webpack-config and https://www.npmjs.com/package/@silverstripe/eslint-config in our modules.
This is locked in the yarn.lock files.

When we are gearing up for a RC, we should release stable versions of the NPM packages, then do a final yarn upgrade @silverstripe/webpack-config @silverstripe/eslint-config and yarn build in all of the modules. This will ensure that all modules are using the correct versions of those libraries and avoid running into issues with them post-stable.

Acceptance Criteria

  • We tag stable relesaes of @silverstripe/webpack-config and @silverstripe/eslint-config
  • All CMS5 modules that rely on webpack config and eslint config use latest version

PRs

@emteknetnz emteknetnz self-assigned this Mar 29, 2023
This was referenced Apr 3, 2023
@maxime-rainville
Copy link
Contributor

All PRs have been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants