Akismet module loads and performs a full table scan on every request (for no reason)

[madmatt]

Loading the AkismetMiddleware on every request doesn't seem necessary, and causes unnecessary database queries to be run even when Akismet isn't in use.

Instead of loading Akismet via a middleware, surely it should just be loaded whenever a form is shown or submitted that includes the AkismetField?

[ScopeyNZ]

I'm not sure that the middleware does anything that's taxing? Looking at it it will only set the API key when the middleware boots up?

[madmatt]

It calls $this->isDBReady() which ultimately does a full table scan. Normally this isn't too bad, but we've run into some issues with MySQL/MariaDB deadlocking these full table scans for... no good reason we can see. We investigated one cause of these table scans and it led back here. It's not the only code doing this, but it seems unnecessary to do this here.

[ScopeyNZ]

I see yeah. isDBReady is usually just a simple "a connection exists" call so I glanced over it. It seems a little odd that it's pretty much just asserting dev/build has been run!

I'd vote we just remove it and have isDBReady just check the connection is ready.