Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DBSchemaManager::alterIndex #11029

Open
sabina-talipova opened this issue Oct 18, 2023 · 0 comments
Open

Remove DBSchemaManager::alterIndex #11029

sabina-talipova opened this issue Oct 18, 2023 · 0 comments
Labels
type/api-break type/enhancement
Milestone
Cleanup later

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Oct 18, 2023 •
edited by GuySartorelli
Loading

Description

DBSchemaManager::alterIndex() isn't called from any core code, and it's extremely unlikely to be called in project code. It should be removed.

See:

silverstripe-framework/src/ORM/Connect/DBSchemaManager.php

Line 977 in cf78a9d

* @todo Find out where this is called from - Is it even used? Aren't indexes always dropped and re-added?

This was referenced Oct 18, 2023
Closed
Merged
@GuySartorelli GuySartorelli changed the title TODO: Investigate is DBSchemaManager::alterIndex used Remove DBSchemaManager::alterIndex Oct 25, 2023
@GuySartorelli GuySartorelli added this to the Silverstripe CMS 6 milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/api-break type/enhancement
Projects
None yet
Milestone
Cleanup later
Development

No branches or pull requests
2 participants
@GuySartorelli @sabina-talipova