TreeDropdownField -> DisableFunction not working

[icecaster]

Module version(s) affected

5

Description

TreeDropdownField & its subclasses (TreeMultiselectField)->DisableFunction not working

How to reproduce

This code should produce a dropdown field of all groups, none should be selectable:

$fields->addFieldToTab(
    "Root.Main",
    TreeMultiselectField::create("Test", "Test")
    ->setDisableFunction(function ($node) {
        return true;
    }
));

Possible Solution

No response

Additional Context

No response

Validations

• Check that there isn't already an issue that reports the same bug
• Double check that your reproduction steps work in a fresh installation of silverstripe/installer (with any code examples you've provided)

PRs

• FIX disable options not working issue on TreeDropdownField silverstripe-admin#1847

[GuySartorelli]

This was fixed as part of bringyourownideas/silverstripe-maintenance#220 - because of the breadth of the changes it won't be tagged until the next minor release.

[GuySartorelli]

Oops, wrong issue

[maxime-rainville]

Looks like this is a frontend problem. The nodes are marked as disabled in the JSON request.

Just seems like the front end doesn't care. Arguably, we should probably have a check to make sure that you get block server side if you pick a disabled option.

[priyashantha]

SilverStripe 5.3 is now released but doesn't seem to be this issue has been resolved yet?

[GuySartorelli]

I assume you're looking at the milestone? Milestones are a rough guess and are a guide to help us work on meaningful work. They are not a guarantee of what will be included in any given release.

If fixing this bug is important to you I recommend opening a pull request that fixes it.

[priyashantha]

@GuySartorelli Did you have any chance to review the PR please?

[GuySartorelli]

PR merged