Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move AssetGalleryField API to AssetAdmin #5725

Closed
12 tasks done
chillu opened this issue Jun 22, 2016 · 4 comments
Closed
12 tasks done

Move AssetGalleryField API to AssetAdmin #5725

chillu opened this issue Jun 22, 2016 · 4 comments
Assignees
@chillu
Labels
affects/v4
Milestone
CMS 4.0.0-alpha2

Comments

@chillu
Copy link
Member

chillu commented Jun 22, 2016 •
edited
Loading

Keeping AssetGalleryField complicates building the admin/assets React UI, since it relies on form schema calls to render the gallery as a form field.

Split out from #5711

  • Use AssetAdmin->getClientConfig() to pass through config values (rather than data attrs on the form field)
  • Move PHP logic from field to AssetAdmin
  • Consolidate API calls, remove unused ones (like getFilesBySibling)
  • Fix search logic
  • Remove unused legacy code from AssetAdmin (e.g. the duplicate addFolder() call)
  • Adjust React init to use URLs in AssetAdmin
  • Remove unused AssetAdmin templates
  • Move DropzoneUploadField instance into the upload API call (this subclass of UploadField could be removed completely, we might just use the Upload class directly)
  • Fix documentation
  • Write tests for createFolder
  • Write tests for createFile
  • Fix unit tests
@chillu chillu added this to the CMS 4.0.0-alpha2 milestone Jun 22, 2016
@chillu chillu self-assigned this Jun 22, 2016
@chillu
Copy link
Member Author

chillu commented Jun 23, 2016 •
edited
Loading

WIP: https://github.com/open-sausages/silverstripe-asset-admin/commits/pulls/4.0/assetadmin-api-refactor
Dependency: #5732

This was referenced Jun 23, 2016
Closed
Merged
@chillu
Copy link
Member Author

chillu commented Jun 29, 2016

PR at silverstripe/silverstripe-asset-admin#202

@tractorcow
Copy link
Contributor

I've given this some peer review. I'll let you respond to my feedback. :)

@tractorcow
Copy link
Contributor

Fixed with silverstripe/silverstripe-asset-admin#202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chillu chillu

Labels
affects/v4
Projects
None yet
Milestone
CMS 4.0.0-alpha2
Development

No branches or pull requests
2 participants
@chillu @tractorcow