Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update with CMS 5 compatibility #40

Closed
GuySartorelli opened this issue Mar 16, 2023 · 1 comment
Closed

Update with CMS 5 compatibility #40

GuySartorelli opened this issue Mar 16, 2023 · 1 comment
Assignees
@maxime-rainville

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Mar 16, 2023 •
edited
Loading

This module template reflects CMS 4 standards. We should update everything and anything necessary for this to be compatible with CMS 5 and reflect the latest best practices. That may just mean updating composer.json dependencies to make it clear this is still relevant, or it may involve more work than that.

The other issues in this repository are also relevant to this work.

Acceptance criteria

  • There's a new CMS5 branch for the repo
  • Readme is updated to match CMS 5.
  • CMS5 branch is the default branch
  • CMS5 branch is updated to reflect current best practice.
  • There's a dummy CI build set up.
  • CMS4 branch is still usable.

PRs
@GuySartorelli GuySartorelli self-assigned this May 4, 2023
@GuySartorelli GuySartorelli mentioned this issue May 4, 2023
Merged
@GuySartorelli GuySartorelli removed their assignment May 4, 2023
@maxime-rainville
Copy link

PR merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxime-rainville maxime-rainville

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maxime-rainville @GuySartorelli