Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpstan/extension-installer should be a composer requirement #4

Open
emteknetnz opened this issue Feb 2, 2024 · 0 comments
Open

phpstan/extension-installer should be a composer requirement #4

emteknetnz opened this issue Feb 2, 2024 · 0 comments

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Feb 2, 2024

"phpstan/extension-installer": "^1.3" was added to module-standardiser as a dev-dependency, along with silverstripe/standards - https://github.com/silverstripe/module-standardiser/pull/33/files#diff-6ea5c1ded94eb095c179fa17eb437bc66833529ec9bc1e34d1bd16853c2ddbd9R44

We should simply make phpstan/extension-installer a composer requirement of silverstripe/standards and remove phpstan/extension-installer as dev dependency from modules. The use case for keeping this optional is very narrow and as far as I know it doesn't matter if it's installed regardless. So we should just simplify things and put it in there.

If we do this, also update module-standariser and run it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant