Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: SubsiteDomain::getSubstitutedDomain() - Refactor domains into separate wildcards / primary domains #543

Closed
sabina-talipova opened this issue Oct 12, 2023 · 3 comments

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Oct 12, 2023

Description

SubsiteDomain::getSubstitutedDomain() - Refactor domains into separate wildcards / primary domains.

If follow logic of existing comments,

- @property string $Domain domain name of this subsite. Can include wildcards.
- If there are wildcards in the primary domain (not recommended), make some educated guesses about what to replace them with:

We are looking * wildcards in some domains like test.*(first-level subdomains - tes.com) in the getSubstitutedDomain method, so I assume, that the main idea here to process wildcards for second-level subdomains, currently we do it like this, see here or any other ways provided wildcards, something like test.*.* (test.test.com) or *.test.* (new.test.com).

See:

* @todo Refactor domains into separate wildcards / primary domains

@GuySartorelli
Copy link
Member

@sabina-talipova Can you please provide more context, or close it if you don't have any additional context? It's not clear what is actually meant to happen for this one.

@sabina-talipova
Copy link
Contributor Author

I've updated ticket. If you think that we shouldn't spend time on it. We can close it.

@GuySartorelli
Copy link
Member

I don't think this is worth spending time on for now. If someone finds that this is a signigicant blocker for their use case they can provide additional context and we can reconsider.

@GuySartorelli GuySartorelli closed this as not planned Won't fix, can't repro, duplicate, stale Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants