Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: Assess whether we require lazy loading limits for the StringTagField #263

Closed
sabina-talipova opened this issue Oct 12, 2023 · 1 comment

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Oct 12, 2023

Description

We need to evaluate the necessity of lazy loading limits for the StringTagField. If unnecessary, we should consider removing this restriction.
See

// @todo do we actually need lazy loading limits for StringTagField?
return array_slice(array_values($items ?? []), 0, $this->getLazyLoadItemLimit());

@GuySartorelli
Copy link
Member

Gonna close this as a "won't do" - the limit is configurable if it's causing problems for anyone.
It could also prevent us from loading a buttload of elements to memory, except that getOptions() isn't implemented in a way that allows that optimisation. That would be a separate card though.

@GuySartorelli GuySartorelli closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants