Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React v18 and warning about an unmet dependency with react-aria-menubutton #1531

Closed
PeterC-DLS opened this issue Dec 8, 2023 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@PeterC-DLS
Copy link
Contributor

Consuming @h5web/lib v10 and installing with pnpm:

WARN  Issues with peer dependencies found
client/component
└─┬ @h5web/lib 10.0.0
  └─┬ react-aria-menubutton 7.0.3
    └── ✕ unmet peer react@"^16.3.0 || ^17.0.0": found 18.2.0

It seems like there's an upstream issue: react-aria-menubutton:#156

@PeterC-DLS PeterC-DLS added the bug Something isn't working label Dec 8, 2023
@axelboc
Copy link
Contributor

axelboc commented Dec 11, 2023

Yeah, sorry for not documenting this anywhere. You can safely ignore the warning or silence it, for instance with the following config in package.json if you use pnpm:

"pnpm": {
  "peerDependencyRules": {
    "allowedVersions": {
      "react-aria-menubutton>react": "18.x"
    }
  }
}

@PeterC-DLS
Copy link
Contributor Author

PeterC-DLS commented Dec 11, 2023

Thanks, this works if I add it to the top-level package.json of a monorepo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants