Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for zfp #73

Closed
hhoeflin opened this issue May 7, 2020 · 6 comments
Closed

Support for zfp #73

hhoeflin opened this issue May 7, 2020 · 6 comments
Milestone

Comments

@hhoeflin
Copy link

hhoeflin commented May 7, 2020

Love hdf5 plugin. Use it for blossc. What would be great it so have lossy compression available. Is there a possibility of supporting zfp.

https://github.com/LLNL/H5Z-ZFP

Thanks!

@vasole
Copy link
Member

vasole commented May 10, 2020

My zfp branch works under windows, but I cannot make it work under linux without passing the location of the hdf5 library as argument:

https://github.com/vasole/hdf5plugin/tree/zfp

@t20100 Should we envisage to include it into the repository under those conditions? The zfp filter under platforms other than windows would have to be built from source passing the location of the HDF5 library. I guess it would work for conda but we would not be able to include zfp support into our wheels.

@vasole
Copy link
Member

vasole commented May 10, 2020

@t20100 The problems come from a plethora of H5?_XXXXXX_g undefined symbols. Most of them from H5E. I have tried to add them to hdf5_dl.c but some are not obvious.

@t20100
Copy link
Member

t20100 commented May 11, 2020

That's due to the weird understanding of constants in libhdf5.
There is already a few in hdf5_dl.c:
https://github.com/silx-kit/hdf5plugin/blob/master/src/hdf5_dl.c#L101
https://github.com/silx-kit/hdf5plugin/blob/master/src/hdf5_dl.c#L146
I'll have a look at it.

@t20100
Copy link
Member

t20100 commented May 12, 2020

Closed by PR #74.
Related issue: #75

@t20100 t20100 closed this as completed May 12, 2020
@t20100 t20100 added this to the 2.3.0 milestone May 12, 2020
@hhoeflin
Copy link
Author

Wow that was fast. Thanks so much!

@vasole
Copy link
Member

vasole commented May 15, 2020

@hhoeflin

Release available from PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants