Fix for issue #20

[mjnaylor8]

Hi I left a comment in issue #20 but in case you don't see that ....

Issue can be fixed my moving one line of code in the init of the SpatialLocationField in forms.py. I suspect this might also be the case if you are using Location Field.

So move the line
self.widget = MapInput(map_attrs=map_attrs, )

below the
super().init(*args, **kwargs)

so the def init is now ....

def __init__(self, *args, **kwargs):
    map_attrs = kwargs.pop("map_attrs", None)

    super().__init__(*args, **kwargs)
    self.widget = MapInput(map_attrs=map_attrs, )
    self.error_messages = {"required": "Please pick a location, it's required", }

[simon-the-shark]

Hi! That's a solution to this problem. Nice job! I will include your fix in next release as soon as possible. You can also make a pull request next time.

[mjnaylor8]

I was going to make a pull request however I have also made some other changes to 1) allow pulling back all the other address fields (also hidden) e.g. country, region, location, address line 1 2) allow selection of map type 3) allow use of cursor to move map (items 2 and 3 as per mapbox documentation) As I have bundled all of these (bad change control I know - a github novice) it was a bit tricky to pull out one fix! If you are interested see fork here https://github.com/mjnaylor8/django-mapbox-location-field <https://github.com/mjnaylor8/django-mapbox-location-field> I also wanted to update to documentation but as it was a fix I wanted to get to you asap. Great plugin by the way! Thanks M

…

On 4 Dec 2020, at 19:09, Szymon Kowaliński ***@***.***> wrote: Hi! That's a solution to this problem. Nice job! I will include your fix in next release as soon as possible. You can also make a pull request next time. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgh.neting.cc%2Fsimon-the-shark%2Fdjango-mapbox-location-field%2Fissues%2F22%23issuecomment-738964142&data=04%7C01%7C%7C22b8f0ab29a54aea147f08d898882732%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637427057825340194%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3JqDAU%2FjceWwoCcY%2FZpyfwCjn4PIv2R9MHeU6znVtPk%3D&reserved=0>, or unsubscribe <https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgh.neting.cc%2Fnotifications%2Funsubscribe-auth%2FAIELXN3ID3ARMTHIZ36XUE3STEXXJANCNFSM4UNJAYTA&data=04%7C01%7C%7C22b8f0ab29a54aea147f08d898882732%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637427057825340194%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=4A%2FkYFlCudaRcSS6rhtFjJiCbuvkfL%2Fdj2pSk5CAFvo%3D&reserved=0>.

[simon-the-shark]

I've included your fix in v1.7.0. Already available on pypi

[simon-the-shark]

Once you're ready, make a pull request and I'll be happy to review your changes. Looking forward to it. Good luck!