Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When you click on the Clear button, the X overlay is not visible #283

Closed
vkurko opened this issue Jun 3, 2021 · 3 comments
Closed

When you click on the Clear button, the X overlay is not visible #283

vkurko opened this issue Jun 3, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@vkurko
Copy link

vkurko commented Jun 3, 2021

What is the current behavior?

When you click on the Clear button, the X overlay is not visible.

Please provide the steps to reproduce and create a JSFiddle.

  1. Open https://simonwep.github.io/pickr/
  2. Click on the color button to show the color picker
  3. Click Clear button

What is the expected behavior?

The color button gets transparent and a X overlay is added to indicate that there's no color selected.

Your environment:

Version (see Pickr.version): 1.8.1
Used bundle (es5 or normal one): es5
Used theme (default is classic): classic
Browser-version: Chrome 89.0.4389.114
Operating-system:  Ubuntu 20.04
@vkurko vkurko added the bug Something isn't working label Jun 3, 2021
@vkurko
Copy link
Author

vkurko commented Jun 3, 2021

It looks like the X overlay was broken in this commit - not all places in the code were replaced with css variables.

For the same reason, the comparison option no longer works.

@simonwep
Copy link
Owner

Okay, related to #286

@vkurko
Copy link
Author

vkurko commented Jul 2, 2021

@simonwep thank you for fixing the issue. Will you publish v1.8.2 to npm? It is still 1.8.1 there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants