Skip to content
This repository has been archived by the owner on Apr 23, 2021. It is now read-only.

Provide a single setup.py to install the full simphony-openfoam plugin #24

Open
itziakos opened this issue May 19, 2015 · 8 comments
Open

Comments

@itziakos
Copy link
Member

There should be only a single top level setup.py that will make sure that the necessary extensions and subpackages are build and installed. The current setup requires to manually build a python extension and install two separate packages. This makes it very difficult (if not impossible) to install and update the simphony-openfoam package using pip (the standard python package installer).

The single setup.py can build the c extension and install a single package. Not two separate as it happens now.

related links:

@itziakos
Copy link
Member Author

It makes it very difficult to integrate openfoam with the rest of the simphony-framework.

@itziakos
Copy link
Member Author

Corrected description of the issue.

@itziakos itziakos added enhancement and removed bug labels May 19, 2015
@itziakos
Copy link
Member Author

For the moment integration can use a workaround but the package setup should be streamlined in one of the future releases.

@ahashibon
Copy link

totally agree!

@jmarcelogimenez
Copy link
Contributor

In the PR #23 we have solved it. Now, only a single setup.py is employed for the installation.

@itziakos
Copy link
Member Author

is there a reason why an Extension command (see https://docs.python.org/2/extending/building.html) was not used?

@itziakos
Copy link
Member Author

Even after #23 was merged there are still two setup.py and the main one calls the second through a bash script. This is not recommended since we are just discarding on the setuptools machinery and we are still installing two separate packages (this is similar the workaround that we have setup in simphony-framework). The two setup.py files should be consolidated and use setuptools so that binary extensions and packages can be built as expected.

@stefanoborini
Copy link
Contributor

Still on topic with involvement of EDM and therefore #100

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants