-
Notifications
You must be signed in to change notification settings - Fork 0
Provide a single setup.py to install the full simphony-openfoam plugin #24
Comments
It makes it very difficult to integrate openfoam with the rest of the simphony-framework. |
Corrected description of the issue. |
For the moment integration can use a workaround but the package setup should be streamlined in one of the future releases. |
totally agree! |
In the PR #23 we have solved it. Now, only a single setup.py is employed for the installation. |
is there a reason why an |
Even after #23 was merged there are still two setup.py and the main one calls the second through a bash script. This is not recommended since we are just discarding on the setuptools machinery and we are still installing two separate packages (this is similar the workaround that we have setup in simphony-framework). The two setup.py files should be consolidated and use |
Still on topic with involvement of EDM and therefore #100 |
There should be only a single top level
setup.py
that will make sure that the necessary extensions and subpackages are build and installed. The current setup requires to manually build a python extension and install two separate packages. This makes it very difficult (if not impossible) to install and update the simphony-openfoam package usingpip
(the standard python package installer).The single
setup.py
can build the c extension and install a single package. Not two separate as it happens now.related links:
The text was updated successfully, but these errors were encountered: