Rename _router property to _authRouter to avoid conflicts
#1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
locks
approved these changes
Jul 16, 2019
|
It appears that if you restart a job that’s part of a stage that failed and it succeeds on the second attempt, the next stage doesn’t run 😬 |
|
@backspace I restarted the build on Travis 👍 |
Turbo87
requested changes
Jul 17, 2019
There was a problem hiding this comment.
The issue is that routes by default now have a _router property and we should avoid overriding that with whatever we want to assign to it. IMHO instead of changing the way we assign that property we should rename it to something that does not conflict with the existing _router property. I would propose renaming it to e.g. _authRouter and keeping the existing computed property code minimize the necessary code changes.
|
👍 understood, done, seems to be working! |
Turbo87
force-pushed
the
authenticated-route-mixin-_router-override
branch
from
e7bc593
to
84c076d
Compare
Turbo87
approved these changes
Jul 17, 2019
Turbo87
changed the title
_router property to _authRouter to avoid conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a subset of #1841 as requested by @locks:
https://discordapp.com/channels/480462759797063690/491905849405472769/600683165929177091