Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isValid assertion #741

Merged
merged 3 commits into from
Jun 22, 2020
Merged

Add isValid assertion #741

merged 3 commits into from
Jun 22, 2020

Conversation

patsy-issa
Copy link
Contributor

Introduces isValid to our assertions, can be utilised in the following way to call checkValidity on the following elements:

assert.dom(HTMLFormElement).isValid();
assert.dom(HTMLInputElement').isValid();
assert.dom(HTMLTextAreaElement).isValid();
assert.dom(HTMLButtonElement).isValid();
assert.dom(HTMLOutputElement).isValid();
assert.dom(HTMLSelectElement).isValid();

@patsy-issa patsy-issa requested a review from Turbo87 June 20, 2020 14:38
@patsy-issa patsy-issa self-assigned this Jun 20, 2020
@scalvert scalvert changed the title Is valid Add isValid assertion Jun 20, 2020
@scalvert
Copy link
Collaborator

This looks great! Would you also mind updating the docs by running yarn docs, and ensure the output makes sense?

Copy link
Collaborator

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@scalvert
Copy link
Collaborator

@patsy-issa I hope you don't mind, I went ahead and regenerated the API docs for you for isValid. This is good to go! Thanks again!

@scalvert scalvert merged commit b8336b8 into mainmatter:master Jun 22, 2020
@patsy-issa patsy-issa deleted the is-valid branch June 24, 2020 18:55
@patsy-issa
Copy link
Contributor Author

@scalvert Awesome, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants