-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpack build fails with version 0.32.0 with error "Default condition should be last one" #699
Comments
@colatkinson Hi, Thanks for reporting (and for the reference links) Yes, this is quite the surprising requirement. I have just published 0.31.1 which ensures the {
...
"types": "./build/require/index.d.ts",
"main": "./build/require/index.js",
"module": "./build/import/index.mjs",
"exports": {
".": {
"require": {
"types": "./build/require/index.d.ts",
"default": "./build/require/index.js"
},
"import": {
"types": "./build/import/index.d.mts",
"default": "./build/import/index.mjs"
}
},
"./compiler": {
"require": {
"types": "./build/require/compiler/index.d.ts",
"default": "./build/require/compiler/index.js"
},
"import": {
"types": "./build/import/compiler/index.d.mts",
"default": "./build/import/compiler/index.mjs"
}
},
"./errors": {
"require": {
"types": "./build/require/errors/index.d.ts",
"default": "./build/require/errors/index.js"
},
"import": {
"types": "./build/import/errors/index.d.mts",
"default": "./build/import/errors/index.mjs"
}
},
"./system": {
"require": {
"types": "./build/require/system/index.d.ts",
"default": "./build/require/system/index.js"
},
"import": {
"types": "./build/import/system/index.d.mts",
"default": "./build/import/system/index.mjs"
}
},
"./type": {
"require": {
"types": "./build/require/type/index.d.ts",
"default": "./build/require/type/index.js"
},
"import": {
"types": "./build/import/type/index.d.mts",
"default": "./build/import/type/index.mjs"
}
},
"./value": {
"require": {
"types": "./build/require/value/index.d.ts",
"default": "./build/require/value/index.js"
},
"import": {
"types": "./build/import/value/index.d.mts",
"default": "./build/import/value/index.mjs"
}
}
} If you can test this against your WebPack installation and let me know this resolves the issue, can close this one off. Thanks again for reporting |
@colatkinson Hey, I actually note this configuration update solved another issue I was facing getting the vscode |
@colatkinson Hiya, Going to close off this issue as the key order has been resolved on 0.32.1. Feel free to ping on this thread if you're still encountering issues. Cheers! |
Hi, sorry for the delayed response. Just wanted to confirm that 0.32.1 does appear to fix the issue. Thanks for looking into it! |
A minimal repro is something like:
This seems to be a pretty common issue across many packages, see e.g. pixijs/pixijs#9691, firebase/firebase-js-sdk#7005, vuetifyjs/vuetify#17436.
This is with node 18.18.0.
So far as I can tell, this is the origin of the error: https://github.com/webpack/enhanced-resolve/blob/58464fc7cb56673c9aa849e68e6300239601e615/lib/util/entrypoints.js#L475
As far as I can tell, the fix is simply to make sure that
default
is the last key in eachexports
entry in thepackage.json
. I tested it locally, and it appears to resolve the issue. Please let me know if there's any additional information I can provide.The text was updated successfully, but these errors were encountered: