get() method's switch to object.prototype.propertyIsEnumerable broke my code

[joshua-golub]

This change was made in July 2016:

use `object.prototype.propertyIsEnumerable instead of `Object.getOwnPropertyDescriptor`

Unfortunately, this change broke my code. Specifically, I was using it like this in the Express framework:

dot = require( "dot-prop" );
req.app.locals.foo = 1;
console.log( "foo = " + dot.get( req, "app.locals.foo" ) );

where the req object is defined here.

Before this change, foo = 1 was logged.
After this change, foo = undefined was logged.

The problem appears to be that req.app isn't an enumerable property because it is an inherited property.

So, here's my question: why are we discriminating against inherited properties inside the get() method? That doesn't seem right to me.

---

IssueHunt Summary

stroncium has been rewarded.

Backers (Total: $40.00)

• issuehunt ($40.00)

Submitted pull Requests

• #54 Changes the way to check property for enumerability, fixes #46

---

Tips

• Checkout the Issuehunt explorer to discover more funded issues.
• Need some help from other developers? Add your repositories on IssueHunt to raise funds.

[OmgImAlexis]

This also affects getters. My current work around is to use dot-prop-immutable.

[IssueHuntBot]

@IssueHunt has funded $40.00 to this issue.

---

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

[issuehunt-oss]

@sindresorhus has rewarded $36.00 to @stroncium. See it on IssueHunt

• 💰 Total deposit: $40.00
• 🎉 Repository reward(0%): $0.00
• 🔧 Service fee(10%): $4.00