no-negation-in-equality-check: Ignore boolean type casting (#2379)

sindresorhus · Jun 14, 2024 · 37e00dd · 37e00dd
1 parent fce6ce3
commit 37e00dd
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 24 deletions.
diff --git a/rules/no-negation-in-equality-check.js b/rules/no-negation-in-equality-check.js
@@ -31,10 +31,11 @@ const create = context => ({
 	BinaryExpression(binaryExpression) {
 		const {operator, left} = binaryExpression;
 
-		if (
-			!isEqualityCheck(binaryExpression)
-			|| !isNegatedExpression(left)
-		) {
+		if (!(
+			isEqualityCheck(binaryExpression)
+			&& isNegatedExpression(left)
+			&& !isNegatedExpression(left.argument)
+		)) {
 			return;
 		}
 

diff --git a/test/no-negation-in-equality-check.mjs b/test/no-negation-in-equality-check.mjs
@@ -8,6 +8,8 @@ test.snapshot({
 		'!foo instanceof bar',
 		'+foo === bar',
 		'!(foo === bar)',
+		'!!foo === bar',
+		'!!!foo === bar',
 		// We are not checking right side
 		'foo === !bar',
 	],
@@ -45,6 +47,5 @@ test.snapshot({
 			foo
 			!/* comment */[a, b].join('') === c
 		`,
-		'!!foo === bar',
 	],
 });
diff --git a/test/snapshots/no-negation-in-equality-check.mjs.md b/test/snapshots/no-negation-in-equality-check.mjs.md
@@ -247,22 +247,3 @@ Generated by [AVA](https://avajs.dev).
       1 | foo␊
       2 | ;/* comment */[a, b].join('') !== c␊
     `
-
-## invalid(11): !!foo === bar
-
-> Input
-
-    `␊
-      1 | !!foo === bar␊
-    `
-
-> Error 1/1
-
-    `␊
-    > 1 | !!foo === bar␊
-        | ^ Negated expression in not allowed in equality check.␊
-    ␊
-    --------------------------------------------------------------------------------␊
-    Suggestion 1/1: Switch to '!==' check.␊
-      1 | !foo !== bar␊
-    `
diff --git a/test/snapshots/no-negation-in-equality-check.mjs.snap b/test/snapshots/no-negation-in-equality-check.mjs.snap