Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A better fix for no-instanceof-array #1020

Merged
merged 6 commits into from
Jan 14, 2021
Merged

A better fix for no-instanceof-array #1020

merged 6 commits into from
Jan 14, 2021

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Jan 14, 2021 •
edited
Loading

  1. Fix Edge case
(0, array) instanceof Array

Was fixed to

Array.isArray(0, array)
  1. keep all comments

@sindresorhus sindresorhus merged commit 0520f31 into sindresorhus:master Jan 14, 2021
@fisker fisker deleted the no-instanceof-array-fix branch January 14, 2021 23:19
@fisker fisker mentioned this pull request Jan 15, 2021
Closed
This was referenced Mar 15, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fisker @sindresorhus