Ignore unexpected case in catch-error-name and prefer-set-has
#1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Tried a lot, can't reproduce #1075 (comment) |
fisker
changed the title
catch-error-name: Add more testscatch-error-name: Fix crash on unexpected case
fisker
changed the title
catch-error-name: Fix crash on unexpected casecatch-error-name and prefer-set-has
fisker
changed the title
catch-error-name and prefer-set-hascatch-error-name and prefer-set-has
| @@ -69,6 +69,13 @@ const create = context => { | |||
| const scope = context.getScope(); | |||
| const variable = findVariable(scope, node); | |||
|
|
|||
| // This was reported https://github.com/sindresorhus/eslint-plugin-unicorn/issues/1075#issuecomment-768072967 | |||
| // But can't reproduce, just ignore this case | |||
There was a problem hiding this comment.
Does this still apply? I noticed you added some tests.
There was a problem hiding this comment.
I don't know, the smoke test failed 3days ago, I can't reproduce. Very strange, same thing happened few days ago https://github.com/sindresorhus/eslint-plugin-unicorn/pull/1045/files#diff-10f1d5918272c29964d48236585e1df3b35709537364651b22f63e9a7e21a3c7R174
Merged
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1075