Smoke tests: Switch custom setup to pre-configured GitHub action #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
changed the title
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces old custom smoke test workflow setup with pre-configured github action. https://github.com/marketplace/actions/eslint-remote-tester-runner
This Github CI action will run
eslint-remote-testerexactly as before. The only addition is that results of the test run are now reported in Github issue in this repository. See example report from here: AriPerkkio#4 and here https://github.com/AriPerkkio/eslint-remote-tester/issues.Results of action run are posted in new Github issue. If old issue has not been closed it will re-use that one and report results in issue comment. If run is successfull (no crashes) no issues or comments are posted.
I also included two repositories which are currently crashing some rule in a separate commit.
Also make sure to check out
eslint-remote-tester-pr-comparatorwhich is used for comparing changes of PR: https://github.com/marketplace/actions/eslint-remote-tester-pr-comparatorLet me know if you want to try this one out too - I can setup PR.