Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule change proposal: Enforce ... over .split('') in prefer-spread #1440

Closed
fisker opened this issue Jul 22, 2021 · 1 comment · Fixed by #1489
Closed

Rule change proposal: Enforce ... over .split('') in prefer-spread #1440

fisker opened this issue Jul 22, 2021 · 1 comment · Fixed by #1489
Assignees
@fisker
Labels
enhancement help wanted

Comments

@fisker
Copy link
Collaborator

fisker commented Jul 22, 2021 •
edited
Loading

When splitting string with '', spread should be preferred.

'🦄'.split('')
// -> (2) ['\uD83E', '\uDD84']

[...'🦄']
// -> ['🦄']

Fail

foo.split('');

Pass

[...foo];
@sindresorhus
Copy link
Owner

This is accepted.

@fisker fisker self-assigned this Aug 16, 2021
@fisker fisker mentioned this issue Aug 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fisker fisker

Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

prefer-spread: Check String#split('') fisker/eslint-plugin-unicorn
2 participants
@sindresorhus @fisker