Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #64

Merged
merged 5 commits into from
Aug 29, 2020
Merged

Upgrade dependencies #64

merged 5 commits into from
Aug 29, 2020

Conversation

fx2000
Copy link
Contributor

@fx2000 fx2000 commented Aug 18, 2020

  • Replaced url-regex dependency with url-regex-safe in response to CVE-2020-7661
  • Updated minimum required node version to v10.12.0 to maintain compatibility with url-regex-safe
  • Added re2 dependency
  • Switched to global URL variable
  • Converted regex capture groups to named capture groups

Fixes #59

- Replaced 'url-regex' dependency with 'url-regex-safe' in response to CVE-2020-7661
- Updated minimum required node version to v10.12.0
- Added 're2' dependency
- Converted regex capture groups to named capture groups
@fx2000 fx2000 changed the title Minor changes to pass tests Fix for CVE-2020-7661 and other minor issues Aug 18, 2020
@fx2000
Copy link
Contributor Author

fx2000 commented Aug 18, 2020

All tests are passing except for Job #134.3, this will fail because url-regex-safe is incompatible with node 8.

@sindresorhus
Copy link
Owner

Thanks for the PR. Next time, please don't open more than one pull request. There's absolutely no reason to open a new one for each update. You should also not do pull requests from the master branch.

package.json Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@fx2000
Copy link
Contributor Author

fx2000 commented Aug 18, 2020

Thanks for the PR. Next time, please don't open more than one pull request. There's absolutely no reason to open a new one for each update. You should also not do pull requests from the master branch.

Duly noted, sorry about that.

@sindresorhus sindresorhus changed the title Fix for CVE-2020-7661 and other minor issues Upgrade dependencies Aug 29, 2020
@sindresorhus sindresorhus merged commit 4fe40da into sindresorhus:master Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Vulnerability] Passing a long string to the url-regex library is resulting in 100% CPU usage
2 participants